From aa332dcc8ed67e3e258036cc3daaaae3268bb902 Mon Sep 17 00:00:00 2001 From: Sandy Carter Date: Sat, 21 Nov 2020 22:18:49 -0500 Subject: [PATCH] threading_posix: Increase stack size in test 16 KB is not enough for the linux thread to be spawned so bump up to 16MB --- src/xenia/base/testing/threading_test.cc | 2 +- src/xenia/base/threading_posix.cc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xenia/base/testing/threading_test.cc b/src/xenia/base/testing/threading_test.cc index f8fae6339..ba6eda0db 100644 --- a/src/xenia/base/testing/threading_test.cc +++ b/src/xenia/base/testing/threading_test.cc @@ -813,7 +813,7 @@ TEST_CASE("Create and Run Thread", "Thread") { result = Wait(Thread::GetCurrentThread(), false, 50ms); REQUIRE(result == WaitResult::kTimeout); - params.stack_size = 16 * 1024; + params.stack_size = 16 * 1024 * 1024; thread = Thread::Create(params, [] { while (true) { Thread::Exit(-1); diff --git a/src/xenia/base/threading_posix.cc b/src/xenia/base/threading_posix.cc index 9e39b17a5..f6a6db193 100644 --- a/src/xenia/base/threading_posix.cc +++ b/src/xenia/base/threading_posix.cc @@ -505,6 +505,7 @@ class PosixCondition : public PosixConditionBase { } } if (pthread_create(&thread_, &attr, ThreadStartRoutine, start_data) != 0) { + pthread_attr_destroy(&attr); return false; } pthread_attr_destroy(&attr);