ShuriZma
/
xenia-canary
mirror of https://github.com/xenia-canary/xenia-canary.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[CPU] break_on_unimplemented_instructions cvar

This commit is contained in:
Triang3l 2020-08-09 22:01:54 +03:00
parent 36501be9f8
commit 9428af52e4
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/xenia/cpu/ppc/ppc_hir_builder.cc
View File

@ -15,6 +15,7 @@
#include "third_party/fmt/include/fmt/format.h" #include "third_party/fmt/include/fmt/format.h"
#include "xenia/base/byte_order.h" #include "xenia/base/byte_order.h"
#include "xenia/base/cvar.h"
#include "xenia/base/logging.h" #include "xenia/base/logging.h"
#include "xenia/base/memory.h" #include "xenia/base/memory.h"
#include "xenia/base/profiling.h" #include "xenia/base/profiling.h"
@ -26,6 +27,12 @@
#include "xenia/cpu/ppc/ppc_opcode_info.h" #include "xenia/cpu/ppc/ppc_opcode_info.h"
#include "xenia/cpu/processor.h" #include "xenia/cpu/processor.h"
DEFINE_bool(
break_on_unimplemented_instructions, true,
"Break to the host debugger (or crash if no debugger attached) if an "
"unimplemented PowerPC instruction is encountered.",
"CPU");
namespace xe { namespace xe {
namespace cpu { namespace cpu {
namespace ppc { namespace ppc {
@ -169,10 +176,14 @@ bool PPCHIRBuilder::Emit(GuestFunction* function, uint32_t flags) {
i.opcode_info = &opcode_info; i.opcode_info = &opcode_info;
if (!opcode_info.emit || opcode_info.emit(*this, i)) { if (!opcode_info.emit || opcode_info.emit(*this, i)) {
auto& disasm_info = GetOpcodeDisasmInfo(opcode); auto& disasm_info = GetOpcodeDisasmInfo(opcode);
XELOGE("Unimplemented instr {:08X} {:08X} {}", address, code, XELOGE(
disasm_info.name); "Unimplemented instr {:08X} {:08X} {} - report the game to Xenia "
"developers; to skip, disable break_on_unimplemented_instructions",
address, code, disasm_info.name);
Comment("UNIMPLEMENTED!"); Comment("UNIMPLEMENTED!");
DebugBreak(); if (cvars::break_on_unimplemented_instructions) {
DebugBreak();
}
} }
} }