[Kernel] (Partially) fix module refcounting
.xex module handles were retained twice in several places, possibly causing them to leak. More placed may have to be fixed too.
This commit is contained in:
parent
803fa0cba9
commit
6630a494ac
|
@ -367,8 +367,7 @@ object_ref<UserModule> KernelState::LoadUserModule(const char* raw_name,
|
|||
// See if we've already loaded it
|
||||
for (auto& existing_module : user_modules_) {
|
||||
if (existing_module->path() == path) {
|
||||
existing_module->Retain();
|
||||
return retain_object(existing_module.get());
|
||||
return existing_module;
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -384,8 +383,7 @@ object_ref<UserModule> KernelState::LoadUserModule(const char* raw_name,
|
|||
|
||||
global_lock.lock();
|
||||
|
||||
// Retain when putting into the listing.
|
||||
module->Retain();
|
||||
// Putting into the listing automatically retains.
|
||||
user_modules_.push_back(module);
|
||||
}
|
||||
|
||||
|
|
|
@ -198,8 +198,10 @@ dword_result_t XexLoadImage(lpstring_t module_name, dword_t module_flags,
|
|||
// Not found; attempt to load as a user module.
|
||||
auto user_module = kernel_state()->LoadUserModule(module_name);
|
||||
if (user_module) {
|
||||
user_module->Retain();
|
||||
hmodule = user_module->hmodule_ptr();
|
||||
// Give up object ownership, this reference will be released by the last
|
||||
// XexUnloadImage call
|
||||
auto user_module_raw = user_module.release();
|
||||
hmodule = user_module_raw->hmodule_ptr();
|
||||
result = X_STATUS_SUCCESS;
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue