From 355e25461e44b85ce6f9d8e6cbf4be1014d9c13f Mon Sep 17 00:00:00 2001
From: Gliniak <Gliniak93@gmail.com>
Date: Fri, 10 Nov 2023 09:15:12 +0100
Subject: [PATCH] [Kernel] Fixed ptr oopsie in XObject destructor

- Removed unnecessary goto statement from XObject::GetNativeObject
- Removed unnecessary comments (obsolete)
- Removed unused code
---
 src/xenia/kernel/xobject.cc | 40 +++++++++++--------------------------
 1 file changed, 12 insertions(+), 28 deletions(-)

diff --git a/src/xenia/kernel/xobject.cc b/src/xenia/kernel/xobject.cc
index 74177d774..9f896258a 100644
--- a/src/xenia/kernel/xobject.cc
+++ b/src/xenia/kernel/xobject.cc
@@ -55,10 +55,10 @@ XObject::~XObject() {
   assert_zero(pointer_ref_count_);
 
   if (allocated_guest_object_) {
-    uint32_t ptr = guest_object_ptr_ - sizeof(X_OBJECT_HEADER);
-    auto header = memory()->TranslateVirtual<X_OBJECT_HEADER*>(ptr);
+    kernel_state()->object_table()->UnmapGuestObjectHostHandle(
+        guest_object_ptr_);
 
-    kernel_state()->object_table()->UnmapGuestObjectHostHandle(ptr);
+    const uint32_t ptr = guest_object_ptr_ - sizeof(X_OBJECT_HEADER);
     memory()->SystemHeapFree(ptr);
   }
 }
@@ -338,9 +338,6 @@ void XObject::SetNativePointer(uint32_t native_ptr, bool uninitialized) {
   // If hit: We've already setup the native ptr with CreateNative!
   assert_zero(guest_object_ptr_);
 
-  // Stash pointer in struct.
-  // FIXME: This assumes the object has a dispatch header (some don't!)
-  //StashHandle(header, handle());
   kernel_state()->object_table()->MapGuestObjectToHostHandle(native_ptr,
                                                              handle());
 
@@ -372,23 +369,15 @@ object_ref<XObject> XObject::GetNativeObject(KernelState* kernel_state,
   if (as_type == -1) {
     as_type = header->type;
   }
-  auto true_object_header =
-      kernel_state->memory()->TranslateVirtual<X_OBJECT_HEADER*>(guest_ptr-sizeof(X_OBJECT_HEADER));
 
   X_HANDLE host_handle;
   
-
   if (kernel_state->object_table()->HostHandleForGuestObject(guest_ptr, host_handle)) {
     // Already initialized.
     // TODO: assert if the type of the object != as_type
-    
-        
     result = kernel_state->object_table()
                  ->LookupObject<XObject>(host_handle, true)
                  .release();
-    goto return_result;
-    // TODO(benvanik): assert nothing has been changed in the struct.
-    // return object;
   } else {
     // First use, create new.
     // https://www.nirsoft.net/kernel_struct/vista/KOBJECTS.html
@@ -431,24 +420,19 @@ object_ref<XObject> XObject::GetNativeObject(KernelState* kernel_state,
       default:
         assert_always();
         result = nullptr;
-        goto return_result;
-
-        // return NULL;
     }
 
-    // Stash pointer in struct.
-    // FIXME: This assumes the object contains a dispatch header (some don't!)
-   // StashHandle(header, object->handle());
-    kernel_state->object_table()->MapGuestObjectToHostHandle(guest_ptr,
-                                                             object->handle());
-    result = object;
-
-  return_result:
-    if (!already_locked) {
-      global_critical_region::mutex().unlock();
+    if (object) {
+      kernel_state->object_table()->MapGuestObjectToHostHandle(
+          guest_ptr, object->handle());
+      result = object;
     }
-    return object_ref<XObject>(result);
   }
+
+  if (!already_locked) {
+    global_critical_region::mutex().unlock();
+  }
+  return object_ref<XObject>(result);
 }
 
 }  // namespace kernel