mirror of https://github.com/xemu-project/xemu.git
faf3b5d86f
write_misa() must use as much common logic as possible. We want to open
code just the bits that are exclusive to the CSR write operation and TCG
internals.
Our validation is done with riscv_cpu_validate_set_extensions(), but we
need a small tweak first. When enabling RVG we're doing:
env->misa_ext |= RVI | RVM | RVA | RVF | RVD;
env->misa_ext_mask = env->misa_ext;
This works fine for realize() time but this can potentially overwrite
env->misa_ext_mask if we reutilize the function for write_misa().
Instead of doing misa_ext_mask = misa_ext, sum up the RVG extensions in
misa_ext_mask as well. This won't change realize() time behavior
(misa_ext_mask will be == misa_ext) and will ensure that write_misa()
won't change misa_ext_mask by accident.
After that, rewrite write_misa() to work as follows:
- mask the write using misa_ext_mask to avoid enabling unsupported
extensions;
- suppress RVC if the next insn isn't aligned;
- disable RVG if any of RVG dependencies are being disabled by the user;
- assign env->misa_ext and run riscv_cpu_validate_set_extensions(). On
error, rollback env->misa_ext to its original value, logging a
GUEST_ERROR to inform the user about the failed write;
- handle RVF and MSTATUS_FS and continue as usual.
Let's keep write_misa() as experimental for now until this logic gains
enough mileage.
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-Id: <20230517135714.211809-12-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
|
||
|---|---|---|
| .. | ||
| insn_trans | ||
| Kconfig | ||
| XVentanaCondOps.decode | ||
| arch_dump.c | ||
| bitmanip_helper.c | ||
| common-semi-target.h | ||
| cpu-param.h | ||
| cpu-qom.h | ||
| cpu.c | ||
| cpu.h | ||
| cpu_bits.h | ||
| cpu_helper.c | ||
| cpu_user.h | ||
| cpu_vendorid.h | ||
| crypto_helper.c | ||
| csr.c | ||
| debug.c | ||
| debug.h | ||
| fpu_helper.c | ||
| gdbstub.c | ||
| helper.h | ||
| insn16.decode | ||
| insn32.decode | ||
| instmap.h | ||
| internals.h | ||
| kvm-stub.c | ||
| kvm.c | ||
| kvm_riscv.h | ||
| m128_helper.c | ||
| machine.c | ||
| meson.build | ||
| monitor.c | ||
| op_helper.c | ||
| pmp.c | ||
| pmp.h | ||
| pmu.c | ||
| pmu.h | ||
| riscv-qmp-cmds.c | ||
| sbi_ecall_interface.h | ||
| time_helper.c | ||
| time_helper.h | ||
| trace-events | ||
| trace.h | ||
| translate.c | ||
| vector_helper.c | ||
| xthead.decode | ||
| zce_helper.c | ||