Peter Maydell 8d37a1425b target/arm: Handle overflow in calculation of next timer tick ... In commit edac4d8a16 back in 2015 when we added support for the virtual timer offset CNTVOFF_EL2, we didn't correctly update the timer-recalculation code that figures out when the timer interrupt is next going to change state. We got it wrong in two ways: * for the 0->1 transition, we didn't notice that gt->cval + offset can overflow a uint64_t * for the 1->0 transition, we didn't notice that the transition might now happen before the count rolls over, if offset > count In the former case, we end up trying to set the next interrupt for a time in the past, which results in QEMU hanging as the timer fires continuously. In the latter case, we would fail to update the interrupt status when we are supposed to. Fix the calculations in both cases. The test case is Alex Bennée's from the bug report, and tests the 0->1 transition overflow case. Fixes: edac4d8a16 ("target-arm: Add CNTVOFF_EL2") Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/60 Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20231120173506.3729884-1-peter.maydell@linaro.org Reviewed-by: Peter Maydell <peter.maydell@linaro.org>		2023-11-27 15:27:36 +00:00
..
boot.S	arm: spelling fixes	2023-07-25 17:13:53 +03:00
kernel.ld	tests/tcg/aarch64: add system boot.S	2019-05-28 10:28:51 +01:00
pauth-3.c	tests/tcg: compile system emulation tests as freestanding	2022-07-06 09:31:16 +02:00
semiconsole.c	tests/tcg: compile system emulation tests as freestanding	2022-07-06 09:31:16 +02:00
semiheap.c	arm: spelling fixes	2023-07-25 17:13:53 +03:00
vtimer.c	target/arm: Handle overflow in calculation of next timer tick	2023-11-27 15:27:36 +00:00