mirror of https://github.com/xemu-project/xemu.git
0a81424def
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
* error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.
ERRP_GUARD() could avoid the case when @errp is the pointer of
error_fatal, the user can't see this additional information, because
exit() happens in error_setg earlier than information is added [1].
The xen_console_connect() passes @errp to error_prepend() without
ERRP_GUARD().
There're 2 places will call xen_console_connect():
- xen_console_realize(): the @errp is from DeviceClass.realize()'s
parameter.
- xen_console_frontend_changed(): the @errp points its caller's
@local_err.
To avoid the issue like [1] said, add missing ERRP_GUARD() at the
beginning of xen_console_connect().
[1]: Issue description in the commit message of commit
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| avr_usart.c | ||
| bcm2835_aux.c | ||
| cadence_uart.c | ||
| cmsdk-apb-uart.c | ||
| debugcon.c | ||
| digic-uart.c | ||
| escc.c | ||
| etraxfs_ser.c | ||
| exynos4210_uart.c | ||
| goldfish_tty.c | ||
| grlib_apbuart.c | ||
| ibex_uart.c | ||
| imx_serial.c | ||
| ipoctal232.c | ||
| mcf_uart.c | ||
| mchp_pfsoc_mmuart.c | ||
| meson.build | ||
| nrf51_uart.c | ||
| omap_uart.c | ||
| parallel-isa.c | ||
| parallel.c | ||
| pl011.c | ||
| renesas_sci.c | ||
| riscv_htif.c | ||
| sclpconsole-lm.c | ||
| sclpconsole.c | ||
| serial-isa.c | ||
| serial-pci-multi.c | ||
| serial-pci.c | ||
| serial.c | ||
| sh_serial.c | ||
| shakti_uart.c | ||
| sifive_uart.c | ||
| spapr_vty.c | ||
| stm32f2xx_usart.c | ||
| terminal3270.c | ||
| trace-events | ||
| trace.h | ||
| virtio-console.c | ||
| virtio-serial-bus.c | ||
| xen_console.c | ||
| xilinx_uartlite.c | ||