ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

esp.c: update esp_fifo_{push, pop}() to call esp_update_drq() 

This ensures that the DRQ line is always set correctly when reading/writing
single bytes to/from the FIFO.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20240324191707.623175-16-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This commit is contained in:
Mark Cave-Ayland 2024-03-24 19:17:04 +00:00
parent 743d873645
commit ffa3a5f2be
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hw/scsi/esp.c
View File

@ -170,10 +170,11 @@ static void esp_fifo_push(ESPState *s, uint8_t val)
{ {
if (fifo8_num_used(&s->fifo) == s->fifo.capacity) { if (fifo8_num_used(&s->fifo) == s->fifo.capacity) {
trace_esp_error_fifo_overrun(); trace_esp_error_fifo_overrun();
return; } else {
fifo8_push(&s->fifo, val);
} }
fifo8_push(&s->fifo, val); esp_update_drq(s);
} }
static void esp_fifo_push_buf(ESPState *s, uint8_t *buf, int len) static void esp_fifo_push_buf(ESPState *s, uint8_t *buf, int len)
@ -184,11 +185,16 @@ static void esp_fifo_push_buf(ESPState *s, uint8_t *buf, int len)
static uint8_t esp_fifo_pop(ESPState *s) static uint8_t esp_fifo_pop(ESPState *s)
{ {
uint8_t val;
if (fifo8_is_empty(&s->fifo)) { if (fifo8_is_empty(&s->fifo)) {
return 0; val = 0;
} else {
val = fifo8_pop(&s->fifo);
} }
return fifo8_pop(&s->fifo); esp_update_drq(s);
return val;
} }
static uint32_t esp_fifo8_pop_buf(Fifo8 *fifo, uint8_t *dest, int maxlen) static uint32_t esp_fifo8_pop_buf(Fifo8 *fifo, uint8_t *dest, int maxlen)