From f94648fe3d298354d9b9fa03d8eaf622d92d781f Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 6 Aug 2018 08:53:23 +0200 Subject: [PATCH] libqtest: Clean up how we read device_del messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit qtest_qmp_device_del() still uses the qmp("") hack to receive a message, even though we have qmp_receive() since commit 66e0c7b187e. Put it to use. Bonus: gets rid of empty format strings. A step towards compile-time format string checking without triggering -Wformat-zero-length. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Eric Blake Message-Id: <20180806065344.7103-3-armbru@redhat.com> --- tests/libqtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 9cb4096639..071d7eb7b1 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id) g_assert(response1); g_assert(!qdict_haskey(response1, "error")); - response2 = qmp(""); + response2 = qmp_receive(); g_assert(response2); g_assert(!qdict_haskey(response2, "error"));