ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vl: Document why objects are delayed 

Objects should not be "delayed" without a reason, as the previous
commit demonstrates.  The remaining ones have reasons.  State them.
and demand future ones come with such a statement.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190604151251.9903-3-armbru@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Markus Armbruster 2019-06-04 17:12:51 +02:00 committed by Paolo Bonzini
parent 9ea18ed25a
commit edfb4389c2
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vl.c
View File

@ -2751,19 +2751,25 @@ static bool object_create_initial(const char *type, QemuOpts *opts)
exit(0); exit(0);
} }
/*
* Objects should not be made "delayed" without a reason. If you
* add one, state the reason in a comment!
*/
/* Reason: rng-egd property "chardev" */
if (g_str_equal(type, "rng-egd")) { if (g_str_equal(type, "rng-egd")) {
return false; return false;
} }
#if defined(CONFIG_VHOST_USER) && defined(CONFIG_LINUX) #if defined(CONFIG_VHOST_USER) && defined(CONFIG_LINUX)
/* Reason: cryptodev-vhost-user property "chardev" */
if (g_str_equal(type, "cryptodev-vhost-user")) { if (g_str_equal(type, "cryptodev-vhost-user")) {
return false; return false;
} }
#endif #endif
/* /*
* return false for concrete netfilters since * Reason: filter-* property "netdev" etc.
* they depend on netdevs already existing
*/ */
if (g_str_equal(type, "filter-buffer") || if (g_str_equal(type, "filter-buffer") ||
g_str_equal(type, "filter-dump") || g_str_equal(type, "filter-dump") ||