qapi: do not protect enum values from namespace pollution

Enum values are always preceded by the uppercase name of the enum, so
they do not conflict with reserved words.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Paolo Bonzini 2012-09-19 16:31:06 +02:00 committed by Luiz Capitulino
parent f513cbf750
commit eda50a656f
3 changed files with 7 additions and 7 deletions

View File

@ -91,9 +91,9 @@ const char *%(name)s_lookup[] = {
def generate_enum_name(name): def generate_enum_name(name):
if name.isupper(): if name.isupper():
return c_fun(name) return c_fun(name, False)
new_name = '' new_name = ''
for c in c_fun(name): for c in c_fun(name, False):
if c.isupper(): if c.isupper():
new_name += '_' new_name += '_'
new_name += c new_name += c

View File

@ -173,7 +173,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
break; break;
''', ''',
abbrev = de_camel_case(name).upper(), abbrev = de_camel_case(name).upper(),
enum = c_fun(de_camel_case(key)).upper(), enum = c_fun(de_camel_case(key),False).upper(),
c_type=members[key], c_type=members[key],
c_name=c_fun(key)) c_name=c_fun(key))

View File

@ -141,7 +141,7 @@ def camel_case(name):
new_name += ch.lower() new_name += ch.lower()
return new_name return new_name
def c_var(name): def c_var(name, protect=True):
# ANSI X3J11/88-090, 3.1.1 # ANSI X3J11/88-090, 3.1.1
c89_words = set(['auto', 'break', 'case', 'char', 'const', 'continue', c89_words = set(['auto', 'break', 'case', 'char', 'const', 'continue',
'default', 'do', 'double', 'else', 'enum', 'extern', 'float', 'default', 'do', 'double', 'else', 'enum', 'extern', 'float',
@ -156,12 +156,12 @@ def c_var(name):
# GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html # GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
# excluding _.* # excluding _.*
gcc_words = set(['asm', 'typeof']) gcc_words = set(['asm', 'typeof'])
if name in c89_words | c99_words | c11_words | gcc_words: if protect and (name in c89_words | c99_words | c11_words | gcc_words):
return "q_" + name return "q_" + name
return name.replace('-', '_').lstrip("*") return name.replace('-', '_').lstrip("*")
def c_fun(name): def c_fun(name, protect=True):
return c_var(name).replace('.', '_') return c_var(name, protect).replace('.', '_')
def c_list_type(name): def c_list_type(name):
return '%sList' % name return '%sList' % name