ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

job: remove outdated AioContext locking comments 

The AioContext lock no longer exists.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20231205182011.1976568-14-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2023-12-05 13:20:10 -05:00 committed by Kevin Wolf
parent e7fc3c4a8c
commit e91083cd3f
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
include/qemu/job.h
View File

@ -67,8 +67,6 @@ typedef struct Job {
/** /**
* The completion function that will be called when the job completes. * The completion function that will be called when the job completes.
* Called with AioContext lock held, since many callback implementations
* use bdrv_* functions that require to hold the lock.
*/ */
BlockCompletionFunc *cb; BlockCompletionFunc *cb;
@ -264,9 +262,6 @@ struct JobDriver {
* *
* This callback will not be invoked if the job has already failed. * This callback will not be invoked if the job has already failed.
* If it fails, abort and then clean will be called. * If it fails, abort and then clean will be called.
*
* Called with AioContext lock held, since many callbacs implementations
* use bdrv_* functions that require to hold the lock.
*/ */
int (*prepare)(Job *job); int (*prepare)(Job *job);
@ -277,9 +272,6 @@ struct JobDriver {
* *
* All jobs will complete with a call to either .commit() or .abort() but * All jobs will complete with a call to either .commit() or .abort() but
* never both. * never both.
*
* Called with AioContext lock held, since many callback implementations
* use bdrv_* functions that require to hold the lock.
*/ */
void (*commit)(Job *job); void (*commit)(Job *job);
@ -290,9 +282,6 @@ struct JobDriver {
* *
* All jobs will complete with a call to either .commit() or .abort() but * All jobs will complete with a call to either .commit() or .abort() but
* never both. * never both.
*
* Called with AioContext lock held, since many callback implementations
* use bdrv_* functions that require to hold the lock.
*/ */
void (*abort)(Job *job); void (*abort)(Job *job);
@ -301,9 +290,6 @@ struct JobDriver {
* .commit() or .abort(). Regardless of which callback is invoked after * .commit() or .abort(). Regardless of which callback is invoked after
* completion, .clean() will always be called, even if the job does not * completion, .clean() will always be called, even if the job does not
* belong to a transaction group. * belong to a transaction group.
*
* Called with AioContext lock held, since many callbacs implementations
* use bdrv_* functions that require to hold the lock.
*/ */
void (*clean)(Job *job); void (*clean)(Job *job);
@ -318,17 +304,12 @@ struct JobDriver {
* READY). * READY).
* (If the callback is NULL, the job is assumed to terminate * (If the callback is NULL, the job is assumed to terminate
* without I/O.) * without I/O.)
*
* Called with AioContext lock held, since many callback implementations
* use bdrv_* functions that require to hold the lock.
*/ */
bool (*cancel)(Job *job, bool force); bool (*cancel)(Job *job, bool force);
/** /**
* Called when the job is freed. * Called when the job is freed.
* Called with AioContext lock held, since many callback implementations
* use bdrv_* functions that require to hold the lock.
*/ */
void (*free)(Job *job); void (*free)(Job *job);
}; };
@ -424,7 +405,6 @@ void job_ref_locked(Job *job);
* Release a reference that was previously acquired with job_ref_locked() or * Release a reference that was previously acquired with job_ref_locked() or
* job_create(). If it's the last reference to the object, it will be freed. * job_create(). If it's the last reference to the object, it will be freed.
* *
* Takes AioContext lock internally to invoke a job->driver callback.
* Called with job lock held. * Called with job lock held.
*/ */
void job_unref_locked(Job *job); void job_unref_locked(Job *job);