From e87fae4c488ff8a10b921311a63f16b94031c611 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Tue, 18 Jul 2017 12:57:38 +0200 Subject: [PATCH] migration: Add TODO comments on duplication of QAPI_CLONE() qmp_query_migrate_parameters() and qmp_migrate_set_parameters() effectively duplicate QAPI_CLONE() inline. Add suitable TODO comments. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- migration/migration.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 88b9277e68..6b4d17fbb5 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -433,6 +433,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp) MigrationParameters *params; MigrationState *s = migrate_get_current(); + /* TODO use QAPI_CLONE() instead of duplicating it inline */ params = g_malloc0(sizeof(*params)); params->has_compress_level = true; params->compress_level = s->parameters.compress_level; @@ -745,6 +746,8 @@ static void migrate_params_apply(MigrationParameters *params) { MigrationState *s = migrate_get_current(); + /* TODO use QAPI_CLONE() instead of duplicating it inline */ + if (params->has_compress_level) { s->parameters.compress_level = params->compress_level; }