ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/sd/sdcard: Remove default case in read/write on DAT lines 

All read/write on DAT lines are explicitly handled.
Reaching this point would be a programming error:
replace by an assertion.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-79-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-06-16 12:39:18 +02:00
parent 48741580a8
commit e2dec2eab0
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hw/sd/sd.c
View File

@ -1949,7 +1949,6 @@ int sd_do_command(SDState *sd, SDRequest *req,
/* Valid command, we can update the 'state before command' bits. /* Valid command, we can update the 'state before command' bits.
* (Do this now so they appear in r1 responses.) * (Do this now so they appear in r1 responses.)
*/ */
sd->current_cmd = req->cmd;
sd->card_status = FIELD_DP32(sd->card_status, CSR, sd->card_status = FIELD_DP32(sd->card_status, CSR,
CURRENT_STATE, last_state); CURRENT_STATE, last_state);
} }
@ -2014,6 +2013,8 @@ send_response:
qemu_hexdump(stderr, "Response", response, rsplen); qemu_hexdump(stderr, "Response", response, rsplen);
#endif #endif
sd->current_cmd = rtype == sd_illegal ? 0 : req->cmd;
return rsplen; return rsplen;
} }
@ -2167,8 +2168,7 @@ void sd_write_byte(SDState *sd, uint8_t value)
break; break;
default: default:
qemu_log_mask(LOG_GUEST_ERROR, "%s: unknown command\n", __func__); g_assert_not_reached();
break;
} }
} }
@ -2234,8 +2234,7 @@ uint8_t sd_read_byte(SDState *sd)
break; break;
default: default:
qemu_log_mask(LOG_GUEST_ERROR, "%s: unknown command\n", __func__); g_assert_not_reached();
return 0x00;
} }
return ret; return ret;