mirror of https://github.com/xemu-project/xemu.git
hw/qxl: exit on failure to register qxl interface
This prevents a segfault later on when the device reset handler tries to access a NULL ssd.worker since interface_attach_worker has not been called. Signed-off-by: Alon Levy <alevy@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
parent
ffe01e599f
commit
e25a0651f4
6
hw/qxl.c
6
hw/qxl.c
|
@ -2037,7 +2037,11 @@ static int qxl_init_common(PCIQXLDevice *qxl)
|
||||||
|
|
||||||
qxl->ssd.qxl.base.sif = &qxl_interface.base;
|
qxl->ssd.qxl.base.sif = &qxl_interface.base;
|
||||||
qxl->ssd.qxl.id = qxl->id;
|
qxl->ssd.qxl.id = qxl->id;
|
||||||
qemu_spice_add_interface(&qxl->ssd.qxl.base);
|
if (qemu_spice_add_interface(&qxl->ssd.qxl.base) != 0) {
|
||||||
|
error_report("qxl interface %d.%d not supported by spice-server\n",
|
||||||
|
SPICE_INTERFACE_QXL_MAJOR, SPICE_INTERFACE_QXL_MINOR);
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl);
|
qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl);
|
||||||
|
|
||||||
init_pipe_signaling(qxl);
|
init_pipe_signaling(qxl);
|
||||||
|
|
Loading…
Reference in New Issue