ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qapi: Reject "Returns" section when command doesn't return anything 

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240227113921.236097-14-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2024-02-27 12:39:21 +01:00
parent ab07e96c46
commit e1f684ea2e
5 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/qapi/parser.py
View File

@ -721,7 +721,12 @@ class QAPIDoc:
self.features[feature.name].connect(feature) self.features[feature.name].connect(feature)
def check_expr(self, expr: QAPIExpression) -> None: def check_expr(self, expr: QAPIExpression) -> None:
if 'command' not in expr: if 'command' in expr:
if self.returns and 'returns' not in expr:
raise QAPISemError(
self.returns.info,
"'Returns' section, but command doesn't return anything")
else:
if self.returns: if self.returns:
raise QAPISemError( raise QAPISemError(
self.returns.info, self.returns.info,

1
tests/qapi-schema/doc-invalid-return2.err Normal file
View File

@ -0,0 +1 @@
doc-invalid-return2.json:5: 'Returns' section, but command doesn't return anything

7
tests/qapi-schema/doc-invalid-return2.json Normal file
View File

@ -0,0 +1,7 @@
# Command doesn't return anything
##
# @foo:
# Returns: blah
##
{ 'command': 'foo' }

0
tests/qapi-schema/doc-invalid-return2.out Normal file
View File

1
tests/qapi-schema/meson.build
View File

@ -79,6 +79,7 @@ schemas = [
'doc-invalid-end.json', 'doc-invalid-end.json',
'doc-invalid-end2.json', 'doc-invalid-end2.json',
'doc-invalid-return.json', 'doc-invalid-return.json',
'doc-invalid-return2.json',
'doc-invalid-section.json', 'doc-invalid-section.json',
'doc-invalid-start.json', 'doc-invalid-start.json',
'doc-missing-colon.json', 'doc-missing-colon.json',