ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CHECKPATCH: Add warning for single else statement. 

For an example:

WARNING: braces {} are necessary even for single statement blocks
+    } else
+        return env->regs[R_EAX];

total: 0 errors, 1 warnings, 41 lines checked
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Don Slutz 2012-09-02 19:22:38 -04:00 committed by Blue Swirl
parent 69402a6944
commit dfe7053a34
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/checkpatch.pl
View File

@ -2547,12 +2547,16 @@ sub process {
$line !~ /\#\s*else/) { $line !~ /\#\s*else/) {
my $allowed = 0; my $allowed = 0;
# Check the pre-context. # Check the pre-context.
if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
print "APW: ALLOWED: pre<$pre> line<$line>\n" my $pre = $1;
if $dbg_adv_apw;
$allowed = 1; if ($line !~ /else/) {
} print "APW: ALLOWED: pre<$pre> line<$line>\n"
if $dbg_adv_apw;
$allowed = 1;
}
}
my ($level, $endln, @chunks) = my ($level, $endln, @chunks) =
ctx_statement_full($linenr, $realcnt, $-[0]); ctx_statement_full($linenr, $realcnt, $-[0]);