ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qdev: Clean up around properties 

include:
1. remove unnecessary declaration of static function
2. fix inconsistency between comment and function name, and typo OOM->QOM
2. update comments of functions, use uniform format(GTK-Doc style)

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Cao jin 2016-04-17 15:45:54 +08:00 committed by Michael Tokarev
parent 3b7c78c83a
commit d9d8d452da
2 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
hw/core/qdev.c
View File

@ -58,9 +58,6 @@ const char *qdev_fw_name(DeviceState *dev)
return object_get_typename(OBJECT(dev)); return object_get_typename(OBJECT(dev));
} }
static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
Error **errp);
static void bus_remove_child(BusState *bus, DeviceState *child) static void bus_remove_child(BusState *bus, DeviceState *child)
{ {
BusChild *kid; BusChild *kid;
@ -733,13 +730,20 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v,
} }
/** /**
* @qdev_add_legacy_property - adds a legacy property * qdev_property_add_legacy:
* @dev: Device to add the property to.
* @prop: The qdev property definition.
* @errp: location to store error information.
* *
* Do not use this is new code! Properties added through this interface will * Add a legacy QOM property to @dev for qdev property @prop.
* be given names and types in the "legacy" namespace. * On error, store error in @errp.
* *
* Legacy properties are string versions of other OOM properties. The format * Legacy properties are string versions of QOM properties. The format of
* of the string depends on the property type. * the string depends on the property type. Legacy properties are only
* needed for "info qtree".
*
* Do not use this is new code! QOM Properties added through this interface
* will be given names in the "legacy" namespace.
*/ */
static void qdev_property_add_legacy(DeviceState *dev, Property *prop, static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
Error **errp) Error **errp)
@ -762,10 +766,14 @@ static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
} }
/** /**
* @qdev_property_add_static - add a @Property to a device. * qdev_property_add_static:
* @dev: Device to add the property to.
* @prop: The qdev property definition.
* @errp: location to store error information.
* *
* Static properties access data in a struct. The actual type of the * Add a static QOM property to @dev for qdev property @prop.
* property and the field depends on the property type. * On error, store error in @errp. Static properties access data in a struct.
* The type of the QOM property is derived from prop->info.
*/ */
void qdev_property_add_static(DeviceState *dev, Property *prop, void qdev_property_add_static(DeviceState *dev, Property *prop,
Error **errp) Error **errp)

10
include/hw/qdev-properties.h
View File

@ -197,8 +197,14 @@ void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *dev,
Property *prop, const char *value); Property *prop, const char *value);
/** /**
* @qdev_property_add_static - add a @Property to a device referencing a * qdev_property_add_static:
* field in a struct. * @dev: Device to add the property to.
* @prop: The qdev property definition.
* @errp: location to store error information.
*
* Add a static QOM property to @dev for qdev property @prop.
* On error, store error in @errp. Static properties access data in a struct.
* The type of the QOM property is derived from prop->info.
*/ */
void qdev_property_add_static(DeviceState *dev, Property *prop, Error **errp); void qdev_property_add_static(DeviceState *dev, Property *prop, Error **errp);