ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spapr: Fix memory leak in h_client_architecture_support() 

This is the only error path that needs to free the previously allocated
ov1.

Reported-by: Coverity (CID 1421924)
Fixes: cbd0d7f363 "spapr: Fail CAS if option vector table cannot be parsed"
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <158481206205.336182.16106097429336044843.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Greg Kurz 2020-03-21 18:34:22 +01:00 committed by David Gibson
parent feb39b6228
commit ce05fa0fcc
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/ppc/spapr_hcall.c
View File

@ -1726,6 +1726,7 @@ static target_ulong h_client_architecture_support(PowerPCCPU *cpu,
} }
ov5_guest = spapr_ovec_parse_vector(ov_table, 5); ov5_guest = spapr_ovec_parse_vector(ov_table, 5);
if (!ov5_guest) { if (!ov5_guest) {
spapr_ovec_cleanup(ov1_guest);
warn_report("guest didn't provide option vector 5"); warn_report("guest didn't provide option vector 5");
return H_PARAMETER; return H_PARAMETER;
} }