mirror of https://github.com/xemu-project/xemu.git
coroutine: Clean up qemu_coroutine_enter()
qemu_coroutine_enter() is now the only user of coroutine_swap(). Both functions are short, so inline it. Also, using COROUTINE_YIELD is now even more confusing because this code is never called during qemu_coroutine_yield() any more. In fact, this value is never read back, so we can just introduce a new COROUTINE_ENTER which documents the purpose of the task switch better. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
315a1309de
commit
cd12bb567c
|
@ -31,6 +31,7 @@
|
||||||
typedef enum {
|
typedef enum {
|
||||||
COROUTINE_YIELD = 1,
|
COROUTINE_YIELD = 1,
|
||||||
COROUTINE_TERMINATE = 2,
|
COROUTINE_TERMINATE = 2,
|
||||||
|
COROUTINE_ENTER = 3,
|
||||||
} CoroutineAction;
|
} CoroutineAction;
|
||||||
|
|
||||||
struct Coroutine {
|
struct Coroutine {
|
||||||
|
|
|
@ -99,29 +99,10 @@ static void coroutine_delete(Coroutine *co)
|
||||||
qemu_coroutine_delete(co);
|
qemu_coroutine_delete(co);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void coroutine_swap(Coroutine *from, Coroutine *to)
|
|
||||||
{
|
|
||||||
CoroutineAction ret;
|
|
||||||
|
|
||||||
ret = qemu_coroutine_switch(from, to, COROUTINE_YIELD);
|
|
||||||
|
|
||||||
qemu_co_queue_run_restart(to);
|
|
||||||
|
|
||||||
switch (ret) {
|
|
||||||
case COROUTINE_YIELD:
|
|
||||||
return;
|
|
||||||
case COROUTINE_TERMINATE:
|
|
||||||
trace_qemu_coroutine_terminate(to);
|
|
||||||
coroutine_delete(to);
|
|
||||||
return;
|
|
||||||
default:
|
|
||||||
abort();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
void qemu_coroutine_enter(Coroutine *co, void *opaque)
|
void qemu_coroutine_enter(Coroutine *co, void *opaque)
|
||||||
{
|
{
|
||||||
Coroutine *self = qemu_coroutine_self();
|
Coroutine *self = qemu_coroutine_self();
|
||||||
|
CoroutineAction ret;
|
||||||
|
|
||||||
trace_qemu_coroutine_enter(self, co, opaque);
|
trace_qemu_coroutine_enter(self, co, opaque);
|
||||||
|
|
||||||
|
@ -132,7 +113,20 @@ void qemu_coroutine_enter(Coroutine *co, void *opaque)
|
||||||
|
|
||||||
co->caller = self;
|
co->caller = self;
|
||||||
co->entry_arg = opaque;
|
co->entry_arg = opaque;
|
||||||
coroutine_swap(self, co);
|
ret = qemu_coroutine_switch(self, co, COROUTINE_ENTER);
|
||||||
|
|
||||||
|
qemu_co_queue_run_restart(co);
|
||||||
|
|
||||||
|
switch (ret) {
|
||||||
|
case COROUTINE_YIELD:
|
||||||
|
return;
|
||||||
|
case COROUTINE_TERMINATE:
|
||||||
|
trace_qemu_coroutine_terminate(co);
|
||||||
|
coroutine_delete(co);
|
||||||
|
return;
|
||||||
|
default:
|
||||||
|
abort();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
void coroutine_fn qemu_coroutine_yield(void)
|
void coroutine_fn qemu_coroutine_yield(void)
|
||||||
|
|
Loading…
Reference in New Issue