ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix race between timer firing vs. alarm_timer->pending = 0 

The period for Win32 timers is very short and always the same
independent of dynticks, so it's possible that the timer fires
before qemu_run_all_timers has reset alarm_timer->pending to zero.
Reset alarm_timer->pending before rearming.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Paolo Bonzini 2010-03-19 11:30:35 +01:00 committed by Aurelien Jarno
parent 06b611c48e
commit ca5a2a4b12
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qemu-timer.c
View File

@ -706,14 +706,14 @@ void configure_icount(const char *option)
void qemu_run_all_timers(void) void qemu_run_all_timers(void)
{ {
alarm_timer->pending = 0;
/* rearm timer, if not periodic */ /* rearm timer, if not periodic */
if (alarm_timer->expired) { if (alarm_timer->expired) {
alarm_timer->expired = 0; alarm_timer->expired = 0;
qemu_rearm_alarm_timer(alarm_timer); qemu_rearm_alarm_timer(alarm_timer);
} }
alarm_timer->pending = 0;
/* vm time timers */ /* vm time timers */
if (vm_running) { if (vm_running) {
qemu_run_timers(vm_clock); qemu_run_timers(vm_clock);