mirror of https://github.com/xemu-project/xemu.git
vfio/ccw: Move VFIODevice initializations in vfio_ccw_instance_init
Some of the VFIODevice initializations is in vfio_ccw_realize, move all of them in vfio_ccw_instance_init. No functional change intended. Suggested-by: Cédric Le Goater <clg@redhat.com> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Eric Farman <farman@linux.ibm.com> Tested-by: Nicolin Chen <nicolinc@nvidia.com> Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
parent
cbbcc2f170
commit
c12b55ad6f
|
@ -594,20 +594,6 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp)
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
vbasedev->ops = &vfio_ccw_ops;
|
|
||||||
vbasedev->type = VFIO_DEVICE_TYPE_CCW;
|
|
||||||
vbasedev->dev = dev;
|
|
||||||
|
|
||||||
/*
|
|
||||||
* All vfio-ccw devices are believed to operate in a way compatible with
|
|
||||||
* discarding of memory in RAM blocks, ie. pages pinned in the host are
|
|
||||||
* in the current working set of the guest driver and therefore never
|
|
||||||
* overlap e.g., with pages available to the guest balloon driver. This
|
|
||||||
* needs to be set before vfio_get_device() for vfio common to handle
|
|
||||||
* ram_block_discard_disable().
|
|
||||||
*/
|
|
||||||
vbasedev->ram_block_discard_allowed = true;
|
|
||||||
|
|
||||||
ret = vfio_attach_device(cdev->mdevid, vbasedev,
|
ret = vfio_attach_device(cdev->mdevid, vbasedev,
|
||||||
&address_space_memory, errp);
|
&address_space_memory, errp);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
|
@ -695,8 +681,22 @@ static const VMStateDescription vfio_ccw_vmstate = {
|
||||||
static void vfio_ccw_instance_init(Object *obj)
|
static void vfio_ccw_instance_init(Object *obj)
|
||||||
{
|
{
|
||||||
VFIOCCWDevice *vcdev = VFIO_CCW(obj);
|
VFIOCCWDevice *vcdev = VFIO_CCW(obj);
|
||||||
|
VFIODevice *vbasedev = &vcdev->vdev;
|
||||||
|
|
||||||
vcdev->vdev.fd = -1;
|
vbasedev->type = VFIO_DEVICE_TYPE_CCW;
|
||||||
|
vbasedev->ops = &vfio_ccw_ops;
|
||||||
|
vbasedev->dev = DEVICE(vcdev);
|
||||||
|
vbasedev->fd = -1;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* All vfio-ccw devices are believed to operate in a way compatible with
|
||||||
|
* discarding of memory in RAM blocks, ie. pages pinned in the host are
|
||||||
|
* in the current working set of the guest driver and therefore never
|
||||||
|
* overlap e.g., with pages available to the guest balloon driver. This
|
||||||
|
* needs to be set before vfio_get_device() for vfio common to handle
|
||||||
|
* ram_block_discard_disable().
|
||||||
|
*/
|
||||||
|
vbasedev->ram_block_discard_allowed = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef CONFIG_IOMMUFD
|
#ifdef CONFIG_IOMMUFD
|
||||||
|
|
Loading…
Reference in New Issue