ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

linux-user/elfload: Lock cpu list and mmap during elf_core_dump 

Do not allow changes to the set of cpus and memory regions
while we are dumping core.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2024-02-26 17:14:22 -10:00
parent e0add9a835
commit b526207765
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
linux-user/elfload.c
View File

@ -4537,13 +4537,11 @@ static void fill_note_info(struct elf_note_info *info,
} }
/* read and fill status of all threads */ /* read and fill status of all threads */
WITH_QEMU_LOCK_GUARD(&qemu_cpu_list_lock) { CPU_FOREACH(cpu) {
CPU_FOREACH(cpu) { if (cpu == thread_cpu) {
if (cpu == thread_cpu) { continue;
continue;
}
fill_thread_info(info, cpu_env(cpu));
} }
fill_thread_info(info, cpu_env(cpu));
} }
} }
@ -4643,6 +4641,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
return 0; return 0;
} }
cpu_list_lock();
mmap_lock();
/* /*
* Walk through target process memory mappings and * Walk through target process memory mappings and
* set up structure containing this information. After * set up structure containing this information. After
@ -4760,6 +4761,8 @@ static int elf_core_dump(int signr, const CPUArchState *env)
out: out:
ret = -errno; ret = -errno;
mmap_unlock();
cpu_list_unlock();
free_note_info(&info); free_note_info(&info);
vma_delete(&mm); vma_delete(&mm);
close(fd); close(fd);