mirror of https://github.com/xemu-project/xemu.git
Stop current VCPU on synchronous reset requests
If some I/O operation ends up calling qemu_system_reset_request in VCPU context, we record this and inform the io-thread, but we do not terminate the VCPU loop. This can lead to fairly unexpected behavior if the triggering reset operation is supposed to work synchronously. Fix this for TCG (when run in deterministic I/O mode) by setting the VCPU on stop and issuing a cpu_exit. KVM requires some more work on its VCPU loop. [ ported from qemu-kvm ] Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
This commit is contained in:
parent
aa2c364b4c
commit
b4a3d965de
17
cpus.c
17
cpus.c
|
@ -312,6 +312,10 @@ void qemu_notify_event(void)
|
|||
void qemu_mutex_lock_iothread(void) {}
|
||||
void qemu_mutex_unlock_iothread(void) {}
|
||||
|
||||
void cpu_stop_current(void)
|
||||
{
|
||||
}
|
||||
|
||||
void vm_stop(int reason)
|
||||
{
|
||||
do_vm_stop(reason);
|
||||
|
@ -852,6 +856,14 @@ static void qemu_system_vmstop_request(int reason)
|
|||
qemu_notify_event();
|
||||
}
|
||||
|
||||
void cpu_stop_current(void)
|
||||
{
|
||||
if (cpu_single_env) {
|
||||
cpu_single_env->stopped = 1;
|
||||
cpu_exit(cpu_single_env);
|
||||
}
|
||||
}
|
||||
|
||||
void vm_stop(int reason)
|
||||
{
|
||||
QemuThread me;
|
||||
|
@ -863,10 +875,7 @@ void vm_stop(int reason)
|
|||
* FIXME: should not return to device code in case
|
||||
* vm_stop() has been requested.
|
||||
*/
|
||||
if (cpu_single_env) {
|
||||
cpu_exit(cpu_single_env);
|
||||
cpu_single_env->stop = 1;
|
||||
}
|
||||
cpu_stop_current();
|
||||
return;
|
||||
}
|
||||
do_vm_stop(reason);
|
||||
|
|
1
cpus.h
1
cpus.h
|
@ -6,6 +6,7 @@ int qemu_init_main_loop(void);
|
|||
void qemu_main_loop_start(void);
|
||||
void resume_all_vcpus(void);
|
||||
void pause_all_vcpus(void);
|
||||
void cpu_stop_current(void);
|
||||
|
||||
/* vl.c */
|
||||
extern int smp_cores;
|
||||
|
|
Loading…
Reference in New Issue