ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/nvram/mac_nvram: Report failure to write data 

There's no way for the macio_nvram device to report failure to write
data, but we can at least report it to the user with error_report()
as we do in other devices like xlnx-efuse.

Spotted by Coverity.

Resolves: Coverity CID 1507628
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240312183810.557768-6-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2024-03-25 10:41:01 +00:00
parent c67f758069
commit b13ba381ca
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/nvram/mac_nvram.c
View File

@ -33,6 +33,7 @@
#include "migration/vmstate.h" #include "migration/vmstate.h"
#include "qemu/cutils.h" #include "qemu/cutils.h"
#include "qemu/module.h" #include "qemu/module.h"
#include "qemu/error-report.h"
#include "trace.h" #include "trace.h"
#include <zlib.h> #include <zlib.h>
@ -48,7 +49,10 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr,
trace_macio_nvram_write(addr, value); trace_macio_nvram_write(addr, value);
s->data[addr] = value; s->data[addr] = value;
if (s->blk) { if (s->blk) {
blk_pwrite(s->blk, addr, 1, &s->data[addr], 0); if (blk_pwrite(s->blk, addr, 1, &s->data[addr], 0) < 0) {
error_report("%s: write of NVRAM data to backing store failed",
blk_name(s->blk));
}
} }
} }