ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

memory: Have memory_region_init_rom_device_nomigrate() return a boolean 

Following the example documented since commit e3fe3988d7
("error: Document Error API usage rules"), have
memory_region_init_rom_device_nomigrate() return a boolean
indicating whether an error is set or not.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Message-Id: <20231120213301.24349-9-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2023-11-20 11:30:34 +01:00
parent b9159451d3
commit ae076b6c39
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/exec/memory.h
View File

@ -1523,8 +1523,10 @@ bool memory_region_init_rom_nomigrate(MemoryRegion *mr,
* must be unique within any device * must be unique within any device
* @size: size of the region. * @size: size of the region.
* @errp: pointer to Error*, to store an error if it happens. * @errp: pointer to Error*, to store an error if it happens.
*
* Return: true on success, else false setting @errp with error.
*/ */
void memory_region_init_rom_device_nomigrate(MemoryRegion *mr, bool memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
Object *owner, Object *owner,
const MemoryRegionOps *ops, const MemoryRegionOps *ops,
void *opaque, void *opaque,

4
system/memory.c
View File

@ -1716,7 +1716,7 @@ bool memory_region_init_rom_nomigrate(MemoryRegion *mr,
return true; return true;
} }
void memory_region_init_rom_device_nomigrate(MemoryRegion *mr, bool memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
Object *owner, Object *owner,
const MemoryRegionOps *ops, const MemoryRegionOps *ops,
void *opaque, void *opaque,
@ -1737,7 +1737,9 @@ void memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
mr->size = int128_zero(); mr->size = int128_zero();
object_unparent(OBJECT(mr)); object_unparent(OBJECT(mr));
error_propagate(errp, err); error_propagate(errp, err);
return false;
} }
return true;
} }
void memory_region_init_iommu(void *_iommu_mr, void memory_region_init_iommu(void *_iommu_mr,