ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

xen-hvm: Mark inappropriate error handling FIXME 

Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450370121-5768-14-git-send-email-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2015-12-17 17:35:21 +01:00
parent 7e274652e4
commit acef5c02e5
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
xen-hvm.c
View File

@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms,
void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr)
{ {
/* FIXME caller ram_block_add() wants error_setg() on failure */
unsigned long nr_pfn; unsigned long nr_pfn;
xen_pfn_t *pfn_list; xen_pfn_t *pfn_list;
int i; int i;
@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data)
int xen_hvm_init(PCMachineState *pcms, int xen_hvm_init(PCMachineState *pcms,
MemoryRegion **ram_memory) MemoryRegion **ram_memory)
{ {
/*
* FIXME Returns -1 without cleaning up on some errors (harmless
* as long as the caller exit()s on error), dies with hw_error()
* on others. hw_error() isn't approprate here. Should probably
* simply exit() on all errors.
*/
int i, rc; int i, rc;
xen_pfn_t ioreq_pfn; xen_pfn_t ioreq_pfn;
xen_pfn_t bufioreq_pfn; xen_pfn_t bufioreq_pfn;