ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vhost-vdpa: tweak the error label in vhost_vdpa_add() 

Introduce new error label to avoid the unnecessary checking of net
pointer.

Fixes: 1e0a84ea49 ("vhost-vdpa: introduce vhost-vdpa net client")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20210903091031.47303-10-jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Jason Wang 2021-09-03 17:10:19 +08:00 committed by Michael S. Tsirkin
parent ab36edcfea
commit a97ef87a20
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
net/vhost-vdpa.c
View File

@ -99,19 +99,18 @@ static int vhost_vdpa_add(NetClientState *ncs, void *be)
net = vhost_net_init(&options); net = vhost_net_init(&options);
if (!net) { if (!net) {
error_report("failed to init vhost_net for queue"); error_report("failed to init vhost_net for queue");
goto err; goto err_init;
} }
s->vhost_net = net; s->vhost_net = net;
ret = vhost_vdpa_net_check_device_id(net); ret = vhost_vdpa_net_check_device_id(net);
if (ret) { if (ret) {
goto err; goto err_check;
} }
return 0; return 0;
err: err_check:
if (net) { vhost_net_cleanup(net);
vhost_net_cleanup(net); g_free(net);
g_free(net); err_init:
}
return -1; return -1;
} }