From a9605e0317c7a6d5e68f3a3b6708c8ef1096f4bc Mon Sep 17 00:00:00 2001 From: Jan Kiszka Date: Tue, 14 Aug 2012 13:43:12 +0200 Subject: [PATCH] kvmvapic: Disable if there is insufficient memory We need at least 1M of RAM to map the option ROM. Otherwise, we will corrupt host memory or even crash: $ qemu-system-x86_64 -nodefaults --enable-kvm -vnc :0 -m 640k Segmentation fault (core dumped) Reported-and-tested-by: Markus Armbruster Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/apic_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index 58e63b00da..371f95d909 100644 --- a/hw/apic_common.c +++ b/hw/apic_common.c @@ -299,7 +299,9 @@ static int apic_init_common(SysBusDevice *dev) sysbus_init_mmio(dev, &s->io_memory); - if (!vapic && s->vapic_control & VAPIC_ENABLE_MASK) { + /* Note: We need at least 1M to map the VAPIC option ROM */ + if (!vapic && s->vapic_control & VAPIC_ENABLE_MASK && + ram_size >= 1024 * 1024) { vapic = sysbus_create_simple("kvmvapic", -1, NULL); } s->vapic = vapic;