ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid trivial redundant buffering of converted attributes

This commit is contained in:
espes 2015-08-22 13:51:04 +10:00
parent b17c9ed5d4
commit a929a69b62
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hw/xbox/nv2a.c
View File

@ -1971,13 +1971,17 @@ static void pgraph_bind_vertex_attributes(NV2AState *d,
} }
} }
attribute->converted_elements = num_elements;
glBindBuffer(GL_ARRAY_BUFFER, attribute->gl_converted_buffer); glBindBuffer(GL_ARRAY_BUFFER, attribute->gl_converted_buffer);
glBufferData(GL_ARRAY_BUFFER, if (num_elements != attribute->converted_elements) {
num_elements * out_stride, glBufferData(GL_ARRAY_BUFFER,
attribute->converted_buffer, num_elements * out_stride,
GL_DYNAMIC_DRAW); attribute->converted_buffer,
GL_DYNAMIC_DRAW);
}
attribute->converted_elements = num_elements;
glVertexAttribPointer(i, glVertexAttribPointer(i,
attribute->converted_count, attribute->converted_count,
@ -4613,7 +4617,9 @@ static void pgraph_method(NV2AState *d,
vertex_attribute->needs_conversion = false; vertex_attribute->needs_conversion = false;
break; break;
case NV097_SET_VERTEX_DATA_ARRAY_FORMAT_TYPE_CMP: case NV097_SET_VERTEX_DATA_ARRAY_FORMAT_TYPE_CMP:
/* "3 signed, normalized components packed in 32-bits. (11,11,10)" */ /* "3 signed, normalized components packed in 32-bits. (11,11,10)"
* TODO: This could use ARB_vertex_type_10f_11f_11f_rev where
* available. */
vertex_attribute->size = 4; vertex_attribute->size = 4;
vertex_attribute->gl_type = GL_FLOAT; vertex_attribute->gl_type = GL_FLOAT;
vertex_attribute->gl_normalize = GL_FALSE; vertex_attribute->gl_normalize = GL_FALSE;