mirror of https://github.com/xemu-project/xemu.git
test-vmstate: Fix memleaks in test_load_qlist
There is memleak in test_load_qlist().It's not a big deal, but test-vmstate will fail if sanitizers is enabled. In addition, "ret" is written twice with the same value in test_gtree_load_iommu(). Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
parent
600fe89d6e
commit
a6fbd63755
|
@ -1241,7 +1241,6 @@ static void test_gtree_load_iommu(void)
|
||||||
TestGTreeIOMMU *orig_iommu = create_iommu();
|
TestGTreeIOMMU *orig_iommu = create_iommu();
|
||||||
QEMUFile *fsave, *fload;
|
QEMUFile *fsave, *fload;
|
||||||
char eof;
|
char eof;
|
||||||
int ret;
|
|
||||||
|
|
||||||
fsave = open_test_file(true);
|
fsave = open_test_file(true);
|
||||||
qemu_put_buffer(fsave, iommu_dump, sizeof(iommu_dump));
|
qemu_put_buffer(fsave, iommu_dump, sizeof(iommu_dump));
|
||||||
|
@ -1250,10 +1249,8 @@ static void test_gtree_load_iommu(void)
|
||||||
|
|
||||||
fload = open_test_file(false);
|
fload = open_test_file(false);
|
||||||
vmstate_load_state(fload, &vmstate_iommu, dest_iommu, 1);
|
vmstate_load_state(fload, &vmstate_iommu, dest_iommu, 1);
|
||||||
ret = qemu_file_get_error(fload);
|
|
||||||
eof = qemu_get_byte(fload);
|
eof = qemu_get_byte(fload);
|
||||||
ret = qemu_file_get_error(fload);
|
g_assert(!qemu_file_get_error(fload));
|
||||||
g_assert(!ret);
|
|
||||||
g_assert_cmpint(orig_iommu->id, ==, dest_iommu->id);
|
g_assert_cmpint(orig_iommu->id, ==, dest_iommu->id);
|
||||||
g_assert_cmpint(eof, ==, QEMU_VM_EOF);
|
g_assert_cmpint(eof, ==, QEMU_VM_EOF);
|
||||||
|
|
||||||
|
@ -1395,6 +1392,7 @@ static void test_load_qlist(void)
|
||||||
compare_containers(orig_container, dest_container);
|
compare_containers(orig_container, dest_container);
|
||||||
free_container(orig_container);
|
free_container(orig_container);
|
||||||
free_container(dest_container);
|
free_container(dest_container);
|
||||||
|
qemu_fclose(fload);
|
||||||
}
|
}
|
||||||
|
|
||||||
typedef struct TmpTestStruct {
|
typedef struct TmpTestStruct {
|
||||||
|
|
Loading…
Reference in New Issue