ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

target/hppa: prevent trashing of temporary in do_depw_sar() 

nullify_over() calls brcond which destroys all temporaries.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20190913101714.29019-3-svens@stackframe.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Sven Schnelle 2019-09-13 12:17:14 +02:00 committed by Richard Henderson
parent 4845f01518
commit a6deecce5b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
target/hppa/translate.c
View File

@ -3404,10 +3404,6 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c,
TCGv_reg mask, tmp, shift, dest; TCGv_reg mask, tmp, shift, dest;
unsigned msb = 1U << (len - 1); unsigned msb = 1U << (len - 1);
if (c) {
nullify_over(ctx);
}
dest = dest_gpr(ctx, rt); dest = dest_gpr(ctx, rt);
shift = tcg_temp_new(); shift = tcg_temp_new();
tmp = tcg_temp_new(); tmp = tcg_temp_new();
@ -3440,11 +3436,17 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c,
static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a) static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a)
{ {
if (a->c) {
nullify_over(ctx);
}
return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r)); return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r));
} }
static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a) static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a)
{ {
if (a->c) {
nullify_over(ctx);
}
return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a->i)); return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a->i));
} }