ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Fix runtime error in test-authz-pam 

A test with sanitizers on macOS shows this error:

    authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1, which is declared to never be null
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/security/pam_appl.h:56:2: note: nonnull attribute specified here

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Stefan Weil 2021-01-28 18:11:27 +01:00 committed by Daniel P. Berrangé
parent f4d87ce47c
commit a07e9fdd33
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test-authz-pam.c
View File

@ -28,7 +28,7 @@
static bool failauth; static bool failauth;
/* /*
* These two functions are exported by libpam.so. * These three functions are exported by libpam.so.
* *
* By defining them again here, our impls are resolved * By defining them again here, our impls are resolved
* by the linker instead of those in libpam.so * by the linker instead of those in libpam.so
@ -50,6 +50,7 @@ pam_start(const char *service_name, const char *user,
failauth = false; failauth = false;
} }
*pamh = (pam_handle_t *)0xbadeaffe;
return PAM_SUCCESS; return PAM_SUCCESS;
} }
@ -65,6 +66,13 @@ pam_acct_mgmt(pam_handle_t *pamh, int flags)
} }
int
pam_end(pam_handle_t *pamh, int status)
{
return PAM_SUCCESS;
}
static void test_authz_unknown_service(void) static void test_authz_unknown_service(void)
{ {
Error *local_err = NULL; Error *local_err = NULL;