From 00b9e2950b2ff93117adc8415f0d01fad271e402 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Wed, 21 Mar 2018 15:25:57 +0000 Subject: [PATCH 1/2] block: drop moderated sheepdog mailing list from MAINTAINERS file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The sheepdog mailing list is setup to stop and queue messages from non-subscribers, pending moderator approval. Unfortunately it seems that the moderation queue is not actively deadlt with. Even when messages are approved, the sender is never added to the whitelist, so every future mail the same sender continues to get stopped for moderation. MAINTAINERS entries should be responsive and not uneccessarily block mails from QEMU contributors, so drop the sheepdog mailing list. Reviewed-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d794bd7a66..39f00d058b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2028,7 +2028,6 @@ Sheepdog M: Liu Yuan M: Jeff Cody L: qemu-block@nongnu.org -L: sheepdog@lists.wpkg.org S: Supported F: block/sheepdog.c T: git git://github.com/codyprime/qemu-kvm-jtc.git block From f5177798d899a2ee2a2d0babd3f5399d0f786333 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Thu, 23 Aug 2018 11:21:43 +0100 Subject: [PATCH 2/2] scripts: report on author emails that are mangled by the mailing list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In some cases the Author: email address in patches submitted to the list gets mangled such that it says John Doe via Qemu-devel This change is a result of workarounds for DMARC policies. Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable. Reviewed-by: Eric Blake Acked-by: Cornelia Huck Signed-off-by: Daniel P. Berrangé --- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3765b0e35e..06ec14e7f7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1402,6 +1402,10 @@ sub process { $is_patch = 1; } + if ($line =~ /^Author: .*via Qemu-devel.*/) { + ERROR("Author email address is mangled by the mailing list\n" . $herecurr); + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report.