ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

memory: Refactor memory_region_clear_coalescing 

Removing the update variable and quit earlier if the memory region has
no coalesced range.  This prepares for the next patch.

Fixes: 3ac7d43a6f
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20190820141328.10009-4-peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Peter Xu 2019-08-20 22:13:27 +08:00 committed by Paolo Bonzini
parent c5b35f03c3
commit 9c1aa1c235
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
memory.c
View File

@ -2281,7 +2281,10 @@ void memory_region_add_coalescing(MemoryRegion *mr,
void memory_region_clear_coalescing(MemoryRegion *mr) void memory_region_clear_coalescing(MemoryRegion *mr)
{ {
CoalescedMemoryRange *cmr; CoalescedMemoryRange *cmr;
bool updated = false;
if (QTAILQ_EMPTY(&mr->coalesced)) {
return;
}
qemu_flush_coalesced_mmio_buffer(); qemu_flush_coalesced_mmio_buffer();
mr->flush_coalesced_mmio = false; mr->flush_coalesced_mmio = false;
@ -2290,13 +2293,10 @@ void memory_region_clear_coalescing(MemoryRegion *mr)
cmr = QTAILQ_FIRST(&mr->coalesced); cmr = QTAILQ_FIRST(&mr->coalesced);
QTAILQ_REMOVE(&mr->coalesced, cmr, link); QTAILQ_REMOVE(&mr->coalesced, cmr, link);
g_free(cmr); g_free(cmr);
updated = true;
} }
if (updated) {
memory_region_update_coalesced_range(mr); memory_region_update_coalesced_range(mr);
} }
}
void memory_region_set_flush_coalesced(MemoryRegion *mr) void memory_region_set_flush_coalesced(MemoryRegion *mr)
{ {