target/ppc: Fix GDB SPR regnum indexing

Fix an off by one bug.

Fixes: 1b53948ff8 ("target/ppc: Use GDBFeature for dynamic XML")
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
This commit is contained in:
Nicholas Piggin 2024-03-08 01:19:30 +10:00
parent 35ac6831d9
commit 99ea316e2a
1 changed files with 3 additions and 4 deletions

View File

@ -324,6 +324,9 @@ static void gdb_gen_spr_feature(CPUState *cs)
continue; continue;
} }
gdb_feature_builder_append_reg(&builder, g_ascii_strdown(spr->name, -1),
TARGET_LONG_BITS, num_regs,
"int", "spr");
/* /*
* GDB identifies registers based on the order they are * GDB identifies registers based on the order they are
* presented in the XML. These ids will not match QEMU's * presented in the XML. These ids will not match QEMU's
@ -334,10 +337,6 @@ static void gdb_gen_spr_feature(CPUState *cs)
*/ */
spr->gdb_id = num_regs; spr->gdb_id = num_regs;
num_regs++; num_regs++;
gdb_feature_builder_append_reg(&builder, g_ascii_strdown(spr->name, -1),
TARGET_LONG_BITS, num_regs,
"int", "spr");
} }
gdb_feature_builder_end(&builder); gdb_feature_builder_end(&builder);