ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qemu-nbd: Fix a memleak in qemu_nbd_client_list() 

When the qio_channel_socket_connect_sync() fails
we should goto 'out' label to free the 'sioc' instead of return.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-Id: <20201130123651.17543-1-alex.chen@huawei.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Alex Chen 2020-11-30 12:36:51 +00:00 committed by Eric Blake
parent 48202c7124
commit 992809bf8b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qemu-nbd.c
View File

@ -181,7 +181,7 @@ static int qemu_nbd_client_list(SocketAddress *saddr, QCryptoTLSCreds *tls,
sioc = qio_channel_socket_new(); sioc = qio_channel_socket_new();
if (qio_channel_socket_connect_sync(sioc, saddr, &err) < 0) { if (qio_channel_socket_connect_sync(sioc, saddr, &err) < 0) {
error_report_err(err); error_report_err(err);
return EXIT_FAILURE; goto out;
} }
rc = nbd_receive_export_list(QIO_CHANNEL(sioc), tls, hostname, &list, rc = nbd_receive_export_list(QIO_CHANNEL(sioc), tls, hostname, &list,
&err); &err);