ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pci core: assert ENOSPC when add capability 

ENOSPC is programming error, assert it for debugging.

cc: Michael S. Tsirkin <mst@redhat.com>
cc: Marcel Apfelbaum <marcel@redhat.com>
cc: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Cao jin 2016-06-10 17:54:22 +08:00 committed by Michael S. Tsirkin
parent 4616e3592b
commit 97fe42f19b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/pci/pci.c
View File

@ -2228,10 +2228,8 @@ int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
if (!offset) { if (!offset) {
offset = pci_find_space(pdev, size); offset = pci_find_space(pdev, size);
if (!offset) { /* out of PCI config space is programming error */
error_setg(errp, "out of PCI config space"); assert(offset);
return -ENOSPC;
}
} else { } else {
/* Verify that capabilities don't overlap. Note: device assignment /* Verify that capabilities don't overlap. Note: device assignment
* depends on this check to verify that the device is not broken. * depends on this check to verify that the device is not broken.