ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests/unit/test-vmstate: Avoid dynamic stack allocation 

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-12-peter.maydell@linaro.org
This commit is contained in:
Philippe Mathieu-Daudé 2022-08-19 16:39:31 +01:00 committed by Peter Maydell
parent 2d5f4a713d
commit 972d325a8d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit/test-vmstate.c
View File

@ -87,17 +87,16 @@ static void save_buffer(const uint8_t *buf, size_t buf_size)
static void compare_vmstate(const uint8_t *wire, size_t size) static void compare_vmstate(const uint8_t *wire, size_t size)
{ {
QEMUFile *f = open_test_file(false); QEMUFile *f = open_test_file(false);
uint8_t result[size]; g_autofree uint8_t *result = g_malloc(size);
/* read back as binary */ /* read back as binary */
g_assert_cmpint(qemu_get_buffer(f, result, sizeof(result)), ==, g_assert_cmpint(qemu_get_buffer(f, result, size), ==, size);
sizeof(result));
g_assert(!qemu_file_get_error(f)); g_assert(!qemu_file_get_error(f));
/* Compare that what is on the file is the same that what we /* Compare that what is on the file is the same that what we
expected to be there */ expected to be there */
SUCCESS(memcmp(result, wire, sizeof(result))); SUCCESS(memcmp(result, wire, size));
/* Must reach EOF */ /* Must reach EOF */
qemu_get_byte(f); qemu_get_byte(f);