From 94726a407c783724713cb7573cd08518f003f1ee Mon Sep 17 00:00:00 2001 From: Matt Borgerson Date: Wed, 25 Mar 2020 23:31:00 -0700 Subject: [PATCH] ui: Always show error if flash path is empty --- softmmu/vl.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 0c4a0a4c7c..2abc91f510 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2918,16 +2918,14 @@ void qemu_init(int argc, char **argv, char **envp) const char *flash_path; xemu_settings_get_string(XEMU_SETTINGS_SYSTEM_FLASH_PATH, &flash_path); autostart = 0; // Do not auto-start the machine without a valid BIOS file - if (strlen(flash_path) > 0) { - if (xemu_check_file(flash_path)) { - char *msg = g_strdup_printf("Failed to open flash file '%s'. Please check machine settings.", flash_path); - xemu_queue_error_message(msg); - g_free(msg); - } else { - fake_argv[fake_argc++] = strdup("-bios"); - fake_argv[fake_argc++] = strdup(flash_path); - autostart = 1; - } + if (xemu_check_file(flash_path)) { + char *msg = g_strdup_printf("Failed to open flash file '%s'. Please check machine settings.", flash_path); + xemu_queue_error_message(msg); + g_free(msg); + } else { + fake_argv[fake_argc++] = strdup("-bios"); + fake_argv[fake_argc++] = strdup(flash_path); + autostart = 1; } int mem;