ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

quorum: modify vote rules for flush operation 

Keep flush interface the same logic as quorum read/write, Otherwise in
following scenario, we'll encounter unexpected errors.

Quorum has two children(A, B). A do flush sucessfully, but B flush failed.
This cause the filesystem of guest become read-only with following errors:

end_request: I/O error, dev vda, sector 11159960
Aborting journal on device vda3-8
EXT4-fs error (device vda3): ext4_journal_start_sb:327: Detected abort journal
EXT4-fs (vda3): Remounting filesystem read-only

Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Changlong Xie 2016-02-26 09:39:02 +08:00 committed by Kevin Wolf
parent 0ae053b7e1
commit 924e8a2bbc
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
block/quorum.c
View File

@ -767,19 +767,30 @@ static coroutine_fn int quorum_co_flush(BlockDriverState *bs)
QuorumVoteValue result_value; QuorumVoteValue result_value;
int i; int i;
int result = 0; int result = 0;
int success_count = 0;
QLIST_INIT(&error_votes.vote_list); QLIST_INIT(&error_votes.vote_list);
error_votes.compare = quorum_64bits_compare; error_votes.compare = quorum_64bits_compare;
for (i = 0; i < s->num_children; i++) { for (i = 0; i < s->num_children; i++) {
result = bdrv_co_flush(s->children[i]->bs); result = bdrv_co_flush(s->children[i]->bs);
result_value.l = result; if (result) {
quorum_count_vote(&error_votes, &result_value, i); quorum_report_bad(QUORUM_OP_TYPE_FLUSH, 0,
bdrv_nb_sectors(s->children[i]->bs),
s->children[i]->bs->node_name, result);
result_value.l = result;
quorum_count_vote(&error_votes, &result_value, i);
} else {
success_count++;
}
} }
winner = quorum_get_vote_winner(&error_votes); if (success_count >= s->threshold) {
result = winner->value.l; result = 0;
} else {
winner = quorum_get_vote_winner(&error_votes);
result = winner->value.l;
}
quorum_free_vote_list(&error_votes); quorum_free_vote_list(&error_votes);
return result; return result;