target/arm: Rename gen_exception_insn to gen_exception_insn_el

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220609202901.1177572-12-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Richard Henderson 2022-06-10 14:32:32 +01:00 committed by Peter Maydell
parent 9c9d03f0c5
commit 8c5d24dc7d
6 changed files with 53 additions and 52 deletions

View File

@ -1161,9 +1161,9 @@ static bool fp_access_check(DisasContext *s)
assert(!s->fp_access_checked); assert(!s->fp_access_checked);
s->fp_access_checked = true; s->fp_access_checked = true;
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_fp_access_trap(1, 0xe, false, 0), syn_fp_access_trap(1, 0xe, false, 0),
s->fp_excp_el); s->fp_excp_el);
return false; return false;
} }
s->fp_access_checked = true; s->fp_access_checked = true;
@ -1179,8 +1179,8 @@ bool sve_access_check(DisasContext *s)
assert(!s->sve_access_checked); assert(!s->sve_access_checked);
s->sve_access_checked = true; s->sve_access_checked = true;
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_sve_access_trap(), s->sve_excp_el); syn_sve_access_trap(), s->sve_excp_el);
return false; return false;
} }
s->sve_access_checked = true; s->sve_access_checked = true;
@ -1816,8 +1816,8 @@ static void gen_sysreg_undef(DisasContext *s, bool isread,
} else { } else {
syndrome = syn_uncategorized(); syndrome = syn_uncategorized();
} }
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, syndrome, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF, syndrome,
default_exception_el(s)); default_exception_el(s));
} }
/* MRS - move from system register /* MRS - move from system register
@ -2069,8 +2069,8 @@ static void disas_exc(DisasContext *s, uint32_t insn)
switch (op2_ll) { switch (op2_ll) {
case 1: /* SVC */ case 1: /* SVC */
gen_ss_advance(s); gen_ss_advance(s);
gen_exception_insn(s, s->base.pc_next, EXCP_SWI, gen_exception_insn_el(s, s->base.pc_next, EXCP_SWI,
syn_aa64_svc(imm16), default_exception_el(s)); syn_aa64_svc(imm16), default_exception_el(s));
break; break;
case 2: /* HVC */ case 2: /* HVC */
if (s->current_el == 0) { if (s->current_el == 0) {
@ -2083,8 +2083,8 @@ static void disas_exc(DisasContext *s, uint32_t insn)
gen_a64_set_pc_im(s->pc_curr); gen_a64_set_pc_im(s->pc_curr);
gen_helper_pre_hvc(cpu_env); gen_helper_pre_hvc(cpu_env);
gen_ss_advance(s); gen_ss_advance(s);
gen_exception_insn(s, s->base.pc_next, EXCP_HVC, gen_exception_insn_el(s, s->base.pc_next, EXCP_HVC,
syn_aa64_hvc(imm16), 2); syn_aa64_hvc(imm16), 2);
break; break;
case 3: /* SMC */ case 3: /* SMC */
if (s->current_el == 0) { if (s->current_el == 0) {
@ -2094,8 +2094,8 @@ static void disas_exc(DisasContext *s, uint32_t insn)
gen_a64_set_pc_im(s->pc_curr); gen_a64_set_pc_im(s->pc_curr);
gen_helper_pre_smc(cpu_env, tcg_constant_i32(syn_aa64_smc(imm16))); gen_helper_pre_smc(cpu_env, tcg_constant_i32(syn_aa64_smc(imm16)));
gen_ss_advance(s); gen_ss_advance(s);
gen_exception_insn(s, s->base.pc_next, EXCP_SMC, gen_exception_insn_el(s, s->base.pc_next, EXCP_SMC,
syn_aa64_smc(imm16), 3); syn_aa64_smc(imm16), 3);
break; break;
default: default:
unallocated_encoding(s); unallocated_encoding(s);
@ -14725,8 +14725,8 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
* Illegal execution state. This has priority over BTI * Illegal execution state. This has priority over BTI
* exceptions, but comes after instruction abort exceptions. * exceptions, but comes after instruction abort exceptions.
*/ */
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_illegalstate(), default_exception_el(s)); syn_illegalstate(), default_exception_el(s));
return; return;
} }
@ -14757,9 +14757,9 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
if (s->btype != 0 if (s->btype != 0
&& s->guarded_page && s->guarded_page
&& !btype_destination_ok(insn, s->bt, s->btype)) { && !btype_destination_ok(insn, s->bt, s->btype)) {
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_btitrap(s->btype), syn_btitrap(s->btype),
default_exception_el(s)); default_exception_el(s));
return; return;
} }
} else { } else {

View File

@ -143,8 +143,8 @@ static bool trans_VSCCLRM(DisasContext *s, arg_VSCCLRM *a)
tcg_gen_brcondi_i32(TCG_COND_EQ, sfpa, 0, s->condlabel); tcg_gen_brcondi_i32(TCG_COND_EQ, sfpa, 0, s->condlabel);
if (s->fp_excp_el != 0) { if (s->fp_excp_el != 0) {
gen_exception_insn(s, s->pc_curr, EXCP_NOCP, gen_exception_insn_el(s, s->pc_curr, EXCP_NOCP,
syn_uncategorized(), s->fp_excp_el); syn_uncategorized(), s->fp_excp_el);
return true; return true;
} }
@ -376,7 +376,7 @@ static bool gen_M_fp_sysreg_write(DisasContext *s, int regno,
if (!vfp_access_check_m(s, true)) { if (!vfp_access_check_m(s, true)) {
/* /*
* This was only a conditional exception, so override * This was only a conditional exception, so override
* gen_exception_insn()'s default to DISAS_NORETURN * gen_exception_insn_el()'s default to DISAS_NORETURN
*/ */
s->base.is_jmp = DISAS_NEXT; s->base.is_jmp = DISAS_NEXT;
break; break;
@ -532,7 +532,7 @@ static bool gen_M_fp_sysreg_read(DisasContext *s, int regno,
if (!vfp_access_check_m(s, true)) { if (!vfp_access_check_m(s, true)) {
/* /*
* This was only a conditional exception, so override * This was only a conditional exception, so override
* gen_exception_insn()'s default to DISAS_NORETURN * gen_exception_insn_el()'s default to DISAS_NORETURN
*/ */
s->base.is_jmp = DISAS_NEXT; s->base.is_jmp = DISAS_NEXT;
break; break;
@ -765,14 +765,14 @@ static bool trans_NOCP(DisasContext *s, arg_nocp *a)
} }
if (a->cp != 10) { if (a->cp != 10) {
gen_exception_insn(s, s->pc_curr, EXCP_NOCP, gen_exception_insn_el(s, s->pc_curr, EXCP_NOCP,
syn_uncategorized(), default_exception_el(s)); syn_uncategorized(), default_exception_el(s));
return true; return true;
} }
if (s->fp_excp_el != 0) { if (s->fp_excp_el != 0) {
gen_exception_insn(s, s->pc_curr, EXCP_NOCP, gen_exception_insn_el(s, s->pc_curr, EXCP_NOCP,
syn_uncategorized(), s->fp_excp_el); syn_uncategorized(), s->fp_excp_el);
return true; return true;
} }

View File

@ -100,8 +100,8 @@ bool mve_eci_check(DisasContext *s)
return true; return true;
default: default:
/* Reserved value: INVSTATE UsageFault */ /* Reserved value: INVSTATE UsageFault */
gen_exception_insn(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(), gen_exception_insn_el(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(),
default_exception_el(s)); default_exception_el(s));
return false; return false;
} }
} }

View File

@ -230,7 +230,7 @@ static bool vfp_access_check_a(DisasContext *s, bool ignore_vfp_enabled)
int coproc = arm_dc_feature(s, ARM_FEATURE_V8) ? 0 : 0xa; int coproc = arm_dc_feature(s, ARM_FEATURE_V8) ? 0 : 0xa;
uint32_t syn = syn_fp_access_trap(1, 0xe, false, coproc); uint32_t syn = syn_fp_access_trap(1, 0xe, false, coproc);
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, syn, s->fp_excp_el); gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF, syn, s->fp_excp_el);
return false; return false;
} }
@ -260,8 +260,8 @@ bool vfp_access_check_m(DisasContext *s, bool skip_context_update)
* the encoding space handled by the patterns in m-nocp.decode, * the encoding space handled by the patterns in m-nocp.decode,
* and for them we may need to raise NOCP here. * and for them we may need to raise NOCP here.
*/ */
gen_exception_insn(s, s->pc_curr, EXCP_NOCP, gen_exception_insn_el(s, s->pc_curr, EXCP_NOCP,
syn_uncategorized(), s->fp_excp_el); syn_uncategorized(), s->fp_excp_el);
return false; return false;
} }

View File

@ -1100,8 +1100,8 @@ static void gen_exception_insn_el_v(DisasContext *s, uint64_t pc, int excp,
s->base.is_jmp = DISAS_NORETURN; s->base.is_jmp = DISAS_NORETURN;
} }
void gen_exception_insn(DisasContext *s, uint64_t pc, int excp, void gen_exception_insn_el(DisasContext *s, uint64_t pc, int excp,
uint32_t syn, uint32_t target_el) uint32_t syn, uint32_t target_el)
{ {
gen_exception_insn_el_v(s, pc, excp, syn, tcg_constant_i32(target_el)); gen_exception_insn_el_v(s, pc, excp, syn, tcg_constant_i32(target_el));
} }
@ -1117,8 +1117,8 @@ static void gen_exception_bkpt_insn(DisasContext *s, uint32_t syn)
void unallocated_encoding(DisasContext *s) void unallocated_encoding(DisasContext *s)
{ {
/* Unallocated and reserved encodings are uncategorized */ /* Unallocated and reserved encodings are uncategorized */
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, syn_uncategorized(), gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF, syn_uncategorized(),
default_exception_el(s)); default_exception_el(s));
} }
/* Force a TB lookup after an instruction that changes the CPU state. */ /* Force a TB lookup after an instruction that changes the CPU state. */
@ -2869,8 +2869,8 @@ static bool msr_banked_access_decode(DisasContext *s, int r, int sysm, int rn,
undef: undef:
/* If we get here then some access check did not pass */ /* If we get here then some access check did not pass */
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_uncategorized(), exc_target); syn_uncategorized(), exc_target);
return false; return false;
} }
@ -5094,7 +5094,8 @@ static void gen_srs(DisasContext *s,
* For the UNPREDICTABLE cases we choose to UNDEF. * For the UNPREDICTABLE cases we choose to UNDEF.
*/ */
if (s->current_el == 1 && !s->ns && mode == ARM_CPU_MODE_MON) { if (s->current_el == 1 && !s->ns && mode == ARM_CPU_MODE_MON) {
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, syn_uncategorized(), 3); gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_uncategorized(), 3);
return; return;
} }
@ -8479,8 +8480,8 @@ static bool trans_WLS(DisasContext *s, arg_WLS *a)
* Do the check-and-raise-exception by hand. * Do the check-and-raise-exception by hand.
*/ */
if (s->fp_excp_el) { if (s->fp_excp_el) {
gen_exception_insn(s, s->pc_curr, EXCP_NOCP, gen_exception_insn_el(s, s->pc_curr, EXCP_NOCP,
syn_uncategorized(), s->fp_excp_el); syn_uncategorized(), s->fp_excp_el);
return true; return true;
} }
} }
@ -8582,8 +8583,8 @@ static bool trans_LE(DisasContext *s, arg_LE *a)
tmp = load_cpu_field(v7m.ltpsize); tmp = load_cpu_field(v7m.ltpsize);
tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 4, skipexc); tcg_gen_brcondi_i32(TCG_COND_EQ, tmp, 4, skipexc);
tcg_temp_free_i32(tmp); tcg_temp_free_i32(tmp);
gen_exception_insn(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(), gen_exception_insn_el(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(),
default_exception_el(s)); default_exception_el(s));
gen_set_label(skipexc); gen_set_label(skipexc);
} }
@ -9053,8 +9054,8 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
* UsageFault exception. * UsageFault exception.
*/ */
if (arm_dc_feature(s, ARM_FEATURE_M)) { if (arm_dc_feature(s, ARM_FEATURE_M)) {
gen_exception_insn(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(), gen_exception_insn_el(s, s->pc_curr, EXCP_INVSTATE, syn_uncategorized(),
default_exception_el(s)); default_exception_el(s));
return; return;
} }
@ -9063,8 +9064,8 @@ static void disas_arm_insn(DisasContext *s, unsigned int insn)
* Illegal execution state. This has priority over BTI * Illegal execution state. This has priority over BTI
* exceptions, but comes after instruction abort exceptions. * exceptions, but comes after instruction abort exceptions.
*/ */
gen_exception_insn(s, s->pc_curr, EXCP_UDEF, gen_exception_insn_el(s, s->pc_curr, EXCP_UDEF,
syn_illegalstate(), default_exception_el(s)); syn_illegalstate(), default_exception_el(s));
return; return;
} }
@ -9633,8 +9634,8 @@ static void thumb_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
* Illegal execution state. This has priority over BTI * Illegal execution state. This has priority over BTI
* exceptions, but comes after instruction abort exceptions. * exceptions, but comes after instruction abort exceptions.
*/ */
gen_exception_insn(dc, dc->pc_curr, EXCP_UDEF, gen_exception_insn_el(dc, dc->pc_curr, EXCP_UDEF,
syn_illegalstate(), default_exception_el(dc)); syn_illegalstate(), default_exception_el(dc));
return; return;
} }
@ -9707,8 +9708,8 @@ static void thumb_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
*/ */
tcg_remove_ops_after(dc->insn_eci_rewind); tcg_remove_ops_after(dc->insn_eci_rewind);
dc->condjmp = 0; dc->condjmp = 0;
gen_exception_insn(dc, dc->pc_curr, EXCP_INVSTATE, syn_uncategorized(), gen_exception_insn_el(dc, dc->pc_curr, EXCP_INVSTATE, syn_uncategorized(),
default_exception_el(dc)); default_exception_el(dc));
} }
arm_post_translate_insn(dc); arm_post_translate_insn(dc);

View File

@ -279,8 +279,8 @@ void arm_jump_cc(DisasCompare *cmp, TCGLabel *label);
void arm_gen_test_cc(int cc, TCGLabel *label); void arm_gen_test_cc(int cc, TCGLabel *label);
MemOp pow2_align(unsigned i); MemOp pow2_align(unsigned i);
void unallocated_encoding(DisasContext *s); void unallocated_encoding(DisasContext *s);
void gen_exception_insn(DisasContext *s, uint64_t pc, int excp, void gen_exception_insn_el(DisasContext *s, uint64_t pc, int excp,
uint32_t syn, uint32_t target_el); uint32_t syn, uint32_t target_el);
/* Return state of Alternate Half-precision flag, caller frees result */ /* Return state of Alternate Half-precision flag, caller frees result */
static inline TCGv_i32 get_ahp_flag(void) static inline TCGv_i32 get_ahp_flag(void)