mirror of https://github.com/xemu-project/xemu.git
cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find
Reusing the have_tb_lock name, which is also defined in translate-all.c, makes code reviewing unnecessarily harder. Avoid potential confusion by renaming the local have_tb_lock variable to something else. Reviewed-by: Richard Henderson <rth@twiddle.net> Signed-off-by: Emilio G. Cota <cota@braap.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
13e1094735
commit
841710c78e
|
@ -372,7 +372,7 @@ static inline TranslationBlock *tb_find(CPUState *cpu,
|
||||||
TranslationBlock *tb;
|
TranslationBlock *tb;
|
||||||
target_ulong cs_base, pc;
|
target_ulong cs_base, pc;
|
||||||
uint32_t flags;
|
uint32_t flags;
|
||||||
bool have_tb_lock = false;
|
bool acquired_tb_lock = false;
|
||||||
|
|
||||||
/* we record a subset of the CPU state. It will
|
/* we record a subset of the CPU state. It will
|
||||||
always be the same before a given translated block
|
always be the same before a given translated block
|
||||||
|
@ -391,7 +391,7 @@ static inline TranslationBlock *tb_find(CPUState *cpu,
|
||||||
*/
|
*/
|
||||||
mmap_lock();
|
mmap_lock();
|
||||||
tb_lock();
|
tb_lock();
|
||||||
have_tb_lock = true;
|
acquired_tb_lock = true;
|
||||||
|
|
||||||
/* There's a chance that our desired tb has been translated while
|
/* There's a chance that our desired tb has been translated while
|
||||||
* taking the locks so we check again inside the lock.
|
* taking the locks so we check again inside the lock.
|
||||||
|
@ -419,15 +419,15 @@ static inline TranslationBlock *tb_find(CPUState *cpu,
|
||||||
#endif
|
#endif
|
||||||
/* See if we can patch the calling TB. */
|
/* See if we can patch the calling TB. */
|
||||||
if (last_tb && !qemu_loglevel_mask(CPU_LOG_TB_NOCHAIN)) {
|
if (last_tb && !qemu_loglevel_mask(CPU_LOG_TB_NOCHAIN)) {
|
||||||
if (!have_tb_lock) {
|
if (!acquired_tb_lock) {
|
||||||
tb_lock();
|
tb_lock();
|
||||||
have_tb_lock = true;
|
acquired_tb_lock = true;
|
||||||
}
|
}
|
||||||
if (!tb->invalid) {
|
if (!tb->invalid) {
|
||||||
tb_add_jump(last_tb, tb_exit, tb);
|
tb_add_jump(last_tb, tb_exit, tb);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (have_tb_lock) {
|
if (acquired_tb_lock) {
|
||||||
tb_unlock();
|
tb_unlock();
|
||||||
}
|
}
|
||||||
return tb;
|
return tb;
|
||||||
|
|
Loading…
Reference in New Issue