From 80f7efaba567a5c25c923e8df30ed5db17198f7a Mon Sep 17 00:00:00 2001
From: Matt Borgerson <contact@mborgerson.com>
Date: Sat, 28 Jun 2025 15:29:17 -0700
Subject: [PATCH] nv2a/glsl: Define inlineValue uniform only when necessary

---
 hw/xbox/nv2a/pgraph/glsl/vsh.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/xbox/nv2a/pgraph/glsl/vsh.c b/hw/xbox/nv2a/pgraph/glsl/vsh.c
index 885ac6ef75..9bce9f30bf 100644
--- a/hw/xbox/nv2a/pgraph/glsl/vsh.c
+++ b/hw/xbox/nv2a/pgraph/glsl/vsh.c
@@ -168,7 +168,8 @@ MString *pgraph_glsl_gen_vsh(const VshState *state, GenVshGlslOptions opts)
         const UniformInfo *info = &VshUniformInfo[i];
         const char *type_str = uniform_element_type_to_str[info->type];
         if (i == VshUniform_inlineValue &&
-            opts.use_push_constants_for_uniform_attrs) {
+            (!state->uniform_attrs ||
+             opts.use_push_constants_for_uniform_attrs)) {
             continue;
         }
         if (info->count == 1) {