mirror of https://github.com/xemu-project/xemu.git
hw/versatile_pci: Expose multiple sysbus mmio regions
Clean up versatile_pci to expose the various PCI mmio regions properly as separate mmio regions rather than as a single mmio which uses callbacks to map and unmap everything. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
parent
dd236a50aa
commit
7d6e771f49
|
@ -272,8 +272,16 @@ static void realview_init(ram_addr_t ram_size,
|
|||
sysbus_create_simple("pl031", 0x10017000, pic[10]);
|
||||
|
||||
if (!is_pb) {
|
||||
dev = sysbus_create_varargs("realview_pci", 0x60000000,
|
||||
pic[48], pic[49], pic[50], pic[51], NULL);
|
||||
dev = qdev_create(NULL, "realview_pci");
|
||||
busdev = sysbus_from_qdev(dev);
|
||||
qdev_init_nofail(dev);
|
||||
sysbus_mmio_map(busdev, 0, 0x61000000); /* PCI self-config */
|
||||
sysbus_mmio_map(busdev, 1, 0x62000000); /* PCI config */
|
||||
sysbus_mmio_map(busdev, 2, 0x63000000); /* PCI I/O */
|
||||
sysbus_connect_irq(busdev, 0, pic[48]);
|
||||
sysbus_connect_irq(busdev, 1, pic[49]);
|
||||
sysbus_connect_irq(busdev, 2, pic[50]);
|
||||
sysbus_connect_irq(busdev, 3, pic[51]);
|
||||
pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci");
|
||||
if (usb_enabled) {
|
||||
usb_ohci_init_pci(pci_bus, -1);
|
||||
|
|
|
@ -58,38 +58,6 @@ static void pci_vpb_set_irq(void *opaque, int irq_num, int level)
|
|||
qemu_set_irq(pic[irq_num], level);
|
||||
}
|
||||
|
||||
|
||||
static void pci_vpb_map(SysBusDevice *dev, target_phys_addr_t base)
|
||||
{
|
||||
PCIVPBState *s = (PCIVPBState *)dev;
|
||||
/* Selfconfig area. */
|
||||
memory_region_add_subregion(get_system_memory(), base + 0x01000000,
|
||||
&s->mem_config);
|
||||
/* Normal config area. */
|
||||
memory_region_add_subregion(get_system_memory(), base + 0x02000000,
|
||||
&s->mem_config2);
|
||||
|
||||
if (s->realview) {
|
||||
/* IO memory area. */
|
||||
memory_region_add_subregion(get_system_memory(), base + 0x03000000,
|
||||
&s->isa);
|
||||
}
|
||||
}
|
||||
|
||||
static void pci_vpb_unmap(SysBusDevice *dev, target_phys_addr_t base)
|
||||
{
|
||||
PCIVPBState *s = (PCIVPBState *)dev;
|
||||
/* Selfconfig area. */
|
||||
memory_region_del_subregion(get_system_memory(), &s->mem_config);
|
||||
/* Normal config area. */
|
||||
memory_region_del_subregion(get_system_memory(), &s->mem_config2);
|
||||
|
||||
if (s->realview) {
|
||||
/* IO memory area. */
|
||||
memory_region_del_subregion(get_system_memory(), &s->isa);
|
||||
}
|
||||
}
|
||||
|
||||
static int pci_vpb_init(SysBusDevice *dev)
|
||||
{
|
||||
PCIVPBState *s = FROM_SYSBUS(PCIVPBState, dev);
|
||||
|
@ -106,16 +74,22 @@ static int pci_vpb_init(SysBusDevice *dev)
|
|||
|
||||
/* ??? Register memory space. */
|
||||
|
||||
/* Our memory regions are:
|
||||
* 0 : PCI self config window
|
||||
* 1 : PCI config window
|
||||
* 2 : PCI IO window (realview_pci only)
|
||||
*/
|
||||
memory_region_init_io(&s->mem_config, &pci_vpb_config_ops, bus,
|
||||
"pci-vpb-selfconfig", 0x1000000);
|
||||
sysbus_init_mmio_region(dev, &s->mem_config);
|
||||
memory_region_init_io(&s->mem_config2, &pci_vpb_config_ops, bus,
|
||||
"pci-vpb-config", 0x1000000);
|
||||
sysbus_init_mmio_region(dev, &s->mem_config2);
|
||||
if (s->realview) {
|
||||
isa_mmio_setup(&s->isa, 0x0100000);
|
||||
sysbus_init_mmio_region(dev, &s->isa);
|
||||
}
|
||||
|
||||
sysbus_init_mmio_cb2(dev, pci_vpb_map, pci_vpb_unmap);
|
||||
|
||||
pci_create_simple(bus, -1, "versatile_pci_host");
|
||||
return 0;
|
||||
}
|
||||
|
|
|
@ -181,6 +181,7 @@ static void versatile_init(ram_addr_t ram_size,
|
|||
qemu_irq pic[32];
|
||||
qemu_irq sic[32];
|
||||
DeviceState *dev, *sysctl;
|
||||
SysBusDevice *busdev;
|
||||
PCIBus *pci_bus;
|
||||
NICInfo *nd;
|
||||
int n;
|
||||
|
@ -219,8 +220,15 @@ static void versatile_init(ram_addr_t ram_size,
|
|||
sysbus_create_simple("pl050_keyboard", 0x10006000, sic[3]);
|
||||
sysbus_create_simple("pl050_mouse", 0x10007000, sic[4]);
|
||||
|
||||
dev = sysbus_create_varargs("versatile_pci", 0x40000000,
|
||||
sic[27], sic[28], sic[29], sic[30], NULL);
|
||||
dev = qdev_create(NULL, "versatile_pci");
|
||||
busdev = sysbus_from_qdev(dev);
|
||||
qdev_init_nofail(dev);
|
||||
sysbus_mmio_map(busdev, 0, 0x41000000); /* PCI self-config */
|
||||
sysbus_mmio_map(busdev, 1, 0x42000000); /* PCI config */
|
||||
sysbus_connect_irq(busdev, 0, sic[27]);
|
||||
sysbus_connect_irq(busdev, 1, sic[28]);
|
||||
sysbus_connect_irq(busdev, 2, sic[29]);
|
||||
sysbus_connect_irq(busdev, 3, sic[30]);
|
||||
pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci");
|
||||
|
||||
/* The Versatile PCI bridge does not provide access to PCI IO space,
|
||||
|
|
Loading…
Reference in New Issue