ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test-blockjob-txn: don't abuse job->blk 

Here we use job->blk to drop our own reference in job cleanup. Let's do
simpler: drop our reference immediately after job creation.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2021-05-06 17:13:54 +03:00
parent df9a316505
commit 7ac68e2920
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/unit/test-blockjob-txn.c
View File

@ -25,14 +25,6 @@ typedef struct {
int *result; int *result;
} TestBlockJob; } TestBlockJob;
static void test_block_job_clean(Job *job)
{
BlockJob *bjob = container_of(job, BlockJob, job);
BlockDriverState *bs = blk_bs(bjob->blk);
bdrv_unref(bs);
}
static int coroutine_fn test_block_job_run(Job *job, Error **errp) static int coroutine_fn test_block_job_run(Job *job, Error **errp)
{ {
TestBlockJob *s = container_of(job, TestBlockJob, common.job); TestBlockJob *s = container_of(job, TestBlockJob, common.job);
@ -73,7 +65,6 @@ static const BlockJobDriver test_block_job_driver = {
.free = block_job_free, .free = block_job_free,
.user_resume = block_job_user_resume, .user_resume = block_job_user_resume,
.run = test_block_job_run, .run = test_block_job_run,
.clean = test_block_job_clean,
}, },
}; };
@ -105,6 +96,7 @@ static BlockJob *test_block_job_start(unsigned int iterations,
s = block_job_create(job_id, &test_block_job_driver, txn, bs, s = block_job_create(job_id, &test_block_job_driver, txn, bs,
0, BLK_PERM_ALL, 0, JOB_DEFAULT, 0, BLK_PERM_ALL, 0, JOB_DEFAULT,
test_block_job_cb, data, &error_abort); test_block_job_cb, data, &error_abort);
bdrv_unref(bs); /* referenced by job now */
s->iterations = iterations; s->iterations = iterations;
s->use_timer = use_timer; s->use_timer = use_timer;
s->rc = rc; s->rc = rc;