From 778d1799397e1353b69f16547d359f944fb49ea6 Mon Sep 17 00:00:00 2001 From: Wen Congyang Date: Fri, 26 Aug 2011 13:00:33 +0300 Subject: [PATCH] pci_bridge: use parent bus's address space The switch to the new memory API caused the following problem: The pci device may call pci_register_bar() to use PCI bus's address space. But we don't init PCI bus's address space if it is not bus 0. A crash was reported: http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02243.html More work will be needed to make bridge filtering work correctly with the memory API. Signed-off-by: Wen Congyang Signed-off-by: Michael S. Tsirkin --- hw/pci_bridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c index 464d89708f..e0b339edb0 100644 --- a/hw/pci_bridge.c +++ b/hw/pci_bridge.c @@ -246,6 +246,9 @@ int pci_bridge_initfn(PCIDevice *dev) br->bus_name); sec_bus->parent_dev = dev; sec_bus->map_irq = br->map_irq; + /* TODO: use memory API to perform memory filtering. */ + sec_bus->address_space_mem = parent->address_space_mem; + sec_bus->address_space_io = parent->address_space_io; QLIST_INIT(&sec_bus->child); QLIST_INSERT_HEAD(&parent->child, sec_bus, sibling);