ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

scripts/qom-fuse: Apply pylint rules 

- Catch specific exceptions from QMP
- Reraise errors with explicit context
- method parameters should match parent's names

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210603003719.1321369-11-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
John Snow 2021-06-02 20:37:10 -04:00
parent d229f1c83d
commit 7552823a36
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/qmp/qom-fuse
View File

@ -23,7 +23,7 @@ from fuse import FUSE, FuseOSError, Operations
sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python')) sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
from qemu.qmp import QEMUMonitorProtocol from qemu.qmp import QEMUMonitorProtocol, QMPResponseError
fuse.fuse_python_api = (0, 2) fuse.fuse_python_api = (0, 2)
@ -47,7 +47,7 @@ class QOMFS(Operations):
try: try:
self.qmp.command('qom-list', path=path) self.qmp.command('qom-list', path=path)
return True return True
except: except QMPResponseError:
return False return False
def is_property(self, path): def is_property(self, path):
@ -59,7 +59,7 @@ class QOMFS(Operations):
if item['name'] == prop: if item['name'] == prop:
return True return True
return False return False
except: except QMPResponseError:
return False return False
def is_link(self, path): def is_link(self, path):
@ -73,10 +73,10 @@ class QOMFS(Operations):
return True return True
return False return False
return False return False
except: except QMPResponseError:
return False return False
def read(self, path, length, offset, fh): def read(self, path, size, offset, fh):
if not self.is_property(path): if not self.is_property(path):
return -ENOENT return -ENOENT
@ -86,13 +86,13 @@ class QOMFS(Operations):
try: try:
data = self.qmp.command('qom-get', path=path, property=prop) data = self.qmp.command('qom-get', path=path, property=prop)
data += '\n' # make values shell friendly data += '\n' # make values shell friendly
except: except QMPResponseError as err:
raise FuseOSError(EPERM) raise FuseOSError(EPERM) from err
if offset > len(data): if offset > len(data):
return '' return ''
return bytes(data[offset:][:length], encoding='utf-8') return bytes(data[offset:][:size], encoding='utf-8')
def readlink(self, path): def readlink(self, path):
if not self.is_link(path): if not self.is_link(path):