ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vfio/common: Introduce a per container device list 

Several functions need to iterate over the VFIO devices attached to
a given container.  This is currently achieved by iterating over the
groups attached to the container and then over the devices in the group.
Let's introduce a per container device list that simplifies this
search.

Per container list is used in below functions:
vfio_devices_all_dirty_tracking
vfio_devices_all_device_dirty_tracking
vfio_devices_all_running_and_mig_active
vfio_devices_dma_logging_stop
vfio_devices_dma_logging_start
vfio_devices_query_dirty_bitmap

This will also ease the migration of IOMMUFD by hiding the group
specificity.

Suggested-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Zhenzhong Duan 2023-10-09 11:09:14 +02:00 committed by Cédric Le Goater
parent c8fcb90c96
commit 7103ef7e76
2 changed files with 67 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
hw/vfio/common.c
View File

@ -218,7 +218,6 @@ bool vfio_device_state_is_precopy(VFIODevice *vbasedev)
static bool vfio_devices_all_dirty_tracking(VFIOContainer *container)
{
VFIOGroup *group;
VFIODevice *vbasedev;
MigrationState *ms = migrate_get_current();
@ -227,8 +226,7 @@ static bool vfio_devices_all_dirty_tracking(VFIOContainer *container)
return false;
}
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
VFIOMigration *migration = vbasedev->migration;
if (!migration) {
@ -241,22 +239,18 @@ static bool vfio_devices_all_dirty_tracking(VFIOContainer *container)
return false;
}
}
}
return true;
}
static bool vfio_devices_all_device_dirty_tracking(VFIOContainer *container)
{
VFIOGroup *group;
VFIODevice *vbasedev;
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
if (!vbasedev->dirty_pages_supported) {
return false;
}
}
}
return true;
}
@ -267,15 +261,13 @@ static bool vfio_devices_all_device_dirty_tracking(VFIOContainer *container)
*/
static bool vfio_devices_all_running_and_mig_active(VFIOContainer *container)
{
VFIOGroup *group;
VFIODevice *vbasedev;
if (!migration_is_active(migrate_get_current())) {
return false;
}
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
VFIOMigration *migration = vbasedev->migration;
if (!migration) {
@ -289,7 +281,6 @@ static bool vfio_devices_all_running_and_mig_active(VFIOContainer *container)
return false;
}
}
}
return true;
}
@ -1187,13 +1178,11 @@ static bool vfio_section_is_vfio_pci(MemoryRegionSection *section,
{
VFIOPCIDevice *pcidev;
VFIODevice *vbasedev;
VFIOGroup *group;
Object *owner;
owner = memory_region_owner(section->mr);
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
if (vbasedev->type != VFIO_DEVICE_TYPE_PCI) {
continue;
}
@ -1202,7 +1191,6 @@ static bool vfio_section_is_vfio_pci(MemoryRegionSection *section,
return true;
}
}
}
return false;
}
@ -1296,14 +1284,12 @@ static void vfio_devices_dma_logging_stop(VFIOContainer *container)
sizeof(uint64_t))] = {};
struct vfio_device_feature *feature = (struct vfio_device_feature *)buf;
VFIODevice *vbasedev;
VFIOGroup *group;
feature->argsz = sizeof(buf);
feature->flags = VFIO_DEVICE_FEATURE_SET |
VFIO_DEVICE_FEATURE_DMA_LOGGING_STOP;
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
if (!vbasedev->dirty_tracking) {
continue;
}
@ -1314,7 +1300,6 @@ static void vfio_devices_dma_logging_stop(VFIOContainer *container)
}
vbasedev->dirty_tracking = false;
}
}
}
static struct vfio_device_feature *
@ -1396,7 +1381,6 @@ static int vfio_devices_dma_logging_start(VFIOContainer *container)
struct vfio_device_feature *feature;
VFIODirtyRanges ranges;
VFIODevice *vbasedev;
VFIOGroup *group;
int ret = 0;
vfio_dirty_tracking_init(container, &ranges);
@ -1406,8 +1390,7 @@ static int vfio_devices_dma_logging_start(VFIOContainer *container)
return -errno;
}
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
if (vbasedev->dirty_tracking) {
continue;
}
@ -1421,7 +1404,6 @@ static int vfio_devices_dma_logging_start(VFIOContainer *container)
}
vbasedev->dirty_tracking = true;
}
}
out:
if (ret) {
@ -1500,11 +1482,9 @@ static int vfio_devices_query_dirty_bitmap(VFIOContainer *container,
hwaddr size)
{
VFIODevice *vbasedev;
VFIOGroup *group;
int ret;
QLIST_FOREACH(group, &container->group_list, container_next) {
QLIST_FOREACH(vbasedev, &group->device_list, next) {
QLIST_FOREACH(vbasedev, &container->device_list, container_next) {
ret = vfio_device_dma_logging_report(vbasedev, iova, size,
vbmap->bitmap);
if (ret) {
@ -1516,7 +1496,6 @@ static int vfio_devices_query_dirty_bitmap(VFIOContainer *container,
return ret;
}
}
}
return 0;
}
@ -2648,6 +2627,7 @@ int vfio_attach_device(char *name, VFIODevice *vbasedev,
int groupid = vfio_device_groupid(vbasedev, errp);
VFIODevice *vbasedev_iter;
VFIOGroup *group;
VFIOContainer *container;
int ret;
if (groupid < 0) {
@ -2671,8 +2651,12 @@ int vfio_attach_device(char *name, VFIODevice *vbasedev,
ret = vfio_get_device(group, name, vbasedev, errp);
if (ret) {
vfio_put_group(group);
return ret;
}
container = group->container;
QLIST_INSERT_HEAD(&container->device_list, vbasedev, container_next);
return ret;
}
@ -2680,6 +2664,7 @@ void vfio_detach_device(VFIODevice *vbasedev)
{
VFIOGroup *group = vbasedev->group;
QLIST_REMOVE(vbasedev, container_next);
trace_vfio_detach_device(vbasedev->name, group->groupid);
vfio_put_base_device(vbasedev);
vfio_put_group(group);

2
include/hw/vfio/vfio-common.h
View File

@ -98,6 +98,7 @@ typedef struct VFIOContainer {
QLIST_HEAD(, VFIOGroup) group_list;
QLIST_HEAD(, VFIORamDiscardListener) vrdl_list;
QLIST_ENTRY(VFIOContainer) next;
QLIST_HEAD(, VFIODevice) device_list;
} VFIOContainer;
typedef struct VFIOGuestIOMMU {
@ -129,6 +130,7 @@ typedef struct VFIODeviceOps VFIODeviceOps;
typedef struct VFIODevice {
QLIST_ENTRY(VFIODevice) next;
QLIST_ENTRY(VFIODevice) container_next;
struct VFIOGroup *group;
char *sysfsdev;
char *name;