ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qemu-ga: fix segv after failure to open log file 

Currently, if we fail to open the specified log file (generally due to a
permissions issue), we'll assign NULL to the logfile handle (stderr,
initially) used by the logging routines, which can cause a segfault to
occur when we attempt to report the error before exiting.

Instead, only re-assign if the open() was successful.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Michael Roth 2012-05-14 16:42:35 -05:00
parent 3674838cd0
commit 6c615ec57e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qemu-ga.c
View File

@ -836,12 +836,13 @@ int main(int argc, char **argv)
become_daemon(pid_filepath); become_daemon(pid_filepath);
} }
if (log_filepath) { if (log_filepath) {
s->log_file = fopen(log_filepath, "a"); FILE *log_file = fopen(log_filepath, "a");
if (!s->log_file) { if (!log_file) {
g_critical("unable to open specified log file: %s", g_critical("unable to open specified log file: %s",
strerror(errno)); strerror(errno));
goto out_bad; goto out_bad;
} }
s->log_file = log_file;
} }
} }